unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 61263@debbugs.gnu.org, danny@spesh.com
Cc: Danny O'Brien <danny@spesh.com>
Subject: [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase.
Date: Sat, 04 Feb 2023 10:07:38 +0000	[thread overview]
Message-ID: <1FBBFFA5-565C-4CD2-8744-518652E1DC53@tobias.gr> (raw)
In-Reply-To: <2f81f17ea425ae674aedb7f92826e58c8bea4412.1675487305.git.danny@spesh.com>

Hi Danny,

Low-quality review incoming.

I've merged the two duplicate-looking bugs 61263 & 61270.  What happened?

When adding new patch files, you need also add them to gnu/local.mk's sorted dist_patch_DATA list.  Thanks for submitting it upstream!

Reviewing the rest in K-9 is difficult because of the sweeping indentation changes.  Could you submit a v2 without them?

I suspect I'm disagreeing with 'guix style' and not with you, but the 'source' , '#t', and comment changes are steps back IMO (that poor "/"!).

As a rule, there's no requirement to blanket reformat existing code in Guix.  'guix style' isn't there yet.

Removing the obsolete '#t's entirely is welcome though—in a separate commit.

Thanks!

T G-R

Sent on the go.  Excuse or enjoy my brevity.




  reply	other threads:[~2023-02-04 10:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-04  5:08 [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase danny
2023-02-04 10:07 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2023-02-05  4:53   ` Danny O'Brien
2023-03-04 16:37     ` [bug#61263] bug#61270: " Ludovic Courtès
2023-03-05  7:24       ` [bug#61270] " Danny O'Brien via Guix-patches via
2023-03-22  2:13         ` bug#61263: bug#61270: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1FBBFFA5-565C-4CD2-8744-518652E1DC53@tobias.gr \
    --to=guix-patches@gnu.org \
    --cc=61263@debbugs.gnu.org \
    --cc=danny@spesh.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).