unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: 68405@debbugs.gnu.org
Cc: Romain GARBAGE <romain.garbage@inria.fr>
Subject: [bug#68405] [PATCH v2] guix: download: Add support for git repositories.
Date: Fri, 12 Jan 2024 16:57:57 +0100	[thread overview]
Message-ID: <87sf32ilx6.fsf@gnu.org> (raw)
In-Reply-To: <20240112151411.22470-2-romain.garbage@inria.fr> (Romain GARBAGE's message of "Fri, 12 Jan 2024 16:12:19 +0100")

Hello!

Romain GARBAGE <romain.garbage@inria.fr> skribis:

> * guix/scripts/download.scm (git-download-to-store*): Add new variable.
>   (copy-recursively-without-dot-git): New variable.
>   (git-download-to-file): Add new variable.
>   (show-help): Add 'git', 'commit', 'branch' and 'recursive'options
>   help message.
>   (%default-options): Add default value for 'git-reference' and
>   'recursive' options.
>   (%options): Add 'git', 'commit', 'branch' and 'recursive' command
>   line options.
>   (guix-download) [hash]: Compute hash with 'file-hash*' instead of
>   'port-hash' from (gcrypt hash) module. This allows us to compute
>   hashes for directories.
> * doc/guix.texi (Invoking guix-download): Add @item entries for
>   `git', `commit', `branch' and `recursive' options. Add a paragraph in
>   the introduction.
> * tests/guix-download.sh: New tests.

Full disclosure: Romain and I work together at Inria.  I’ve reviewed the
changes and they LGTM, but we’ll leave time for others to chime in.

Ludo’.




  reply	other threads:[~2024-01-12 15:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 15:12 [bug#68405] [PATCH v2] guix: download: Add support for git repositories Romain GARBAGE
2024-01-12 15:57 ` Ludovic Courtès [this message]
2024-01-19  4:16 ` Maxim Cournoyer
2024-01-19  8:53   ` Romain Garbage
2024-01-19 10:19 ` [bug#68405] [PATCH v4] " Romain GARBAGE
2024-01-20  3:23   ` Maxim Cournoyer
2024-01-22 10:39     ` Romain Garbage
2024-01-22 10:32 ` [bug#68405] [PATCH v5] " Romain GARBAGE
2024-01-23 14:06   ` bug#68405: bug#68499: [PATCH v3] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf32ilx6.fsf@gnu.org \
    --to=ludovic.courtes@inria.fr \
    --cc=68405@debbugs.gnu.org \
    --cc=romain.garbage@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).