From: Romain Garbage <romain.garbage@inria.fr>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 68405 <68405@debbugs.gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#68405] [PATCH v4] guix: download: Add support for git repositories.
Date: Mon, 22 Jan 2024 11:39:51 +0100 (CET) [thread overview]
Message-ID: <555736077.15526795.1705919991769.JavaMail.zimbra@inria.fr> (raw)
In-Reply-To: <87v87ohene.fsf@gmail.com>
Hello,
----- Mail original -----
> De: "Maxim Cournoyer" <maxim.cournoyer@gmail.com>
> À: "Romain Garbage" <romain.garbage@inria.fr>
> Cc: "68405" <68405@debbugs.gnu.org>, "Ludovic Courtès" <ludo@gnu.org>
> Envoyé: Samedi 20 Janvier 2024 03:23:01
> Objet: Re: [PATCH v4] guix: download: Add support for git repositories.
[...]
>> + (with-store store
>> + ;; TODO: Verify certificate support and deactivation.
>> + (with-git-error-handling
>> + (latest-repository-commit store url #:recursive? recursive? #:ref
>> reference)))))
>
> The above contains too long lines still :-).
Sorry, I missed them, I sent a v5 hopefully wrapping all the lines longer than 80 characters :)
[...]
> Otherwise, I've tested it with:
>
> --8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix download -gr
> https://git.jami.net/savoirfairelinux/jami-client-qt -o /tmp/jami
> --8<---------------cut here---------------end--------------->8---
>
> and it worked as advertised; very nice!
>
> Some idea for the future: the --recurse option could take an optional
> argument that'd be a comma-separated list of submodules to fetch, e.g.
>
> --8<---------------cut here---------------start------------->8---
> ./pre-inst-env guix download --git \
> --recurse=daemon,3rdparty/SortFilterProxyModel \
> https://git.jami.net/savoirfairelinux/jami-client-qt -o /tmp/jami
> --8<---------------cut here---------------end--------------->8---
>
> and it'd recurse *only* the listed submodules. This would be useful as
> some projects contain submodules for windows or other platforms we do
> not care about and they may be very large (heavy) to download.
>
> The same idea could be implemented for our git-reference, where
> recursive? could accept a git submodule names list.
That's actually a nice idea. I will see if I can find some time to add it to a later patch.
> But back to the current scope:
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Thank you for your review !
--
Romain
next prev parent reply other threads:[~2024-01-22 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 15:12 [bug#68405] [PATCH v2] guix: download: Add support for git repositories Romain GARBAGE
2024-01-12 15:57 ` Ludovic Courtès
2024-01-19 4:16 ` Maxim Cournoyer
2024-01-19 8:53 ` Romain Garbage
2024-01-19 10:19 ` [bug#68405] [PATCH v4] " Romain GARBAGE
2024-01-20 3:23 ` Maxim Cournoyer
2024-01-22 10:39 ` Romain Garbage [this message]
2024-01-22 10:32 ` [bug#68405] [PATCH v5] " Romain GARBAGE
2024-01-23 14:06 ` bug#68405: bug#68499: [PATCH v3] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555736077.15526795.1705919991769.JavaMail.zimbra@inria.fr \
--to=romain.garbage@inria.fr \
--cc=68405@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).