* [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
@ 2017-12-16 19:18 Christopher Baines
2017-12-17 16:10 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Christopher Baines @ 2017-12-16 19:18 UTC (permalink / raw)
To: 29739
Quote the list of hosts, to avoid generating a broken job definition.
* gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
passing them in to the job gexp.
---
gnu/services/certbot.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index dc072ea8d..0d72a4b70 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -72,7 +72,7 @@
(string-concatenate
(map (lambda (host)
(string-append " -d " host))
- #$hosts))))))))))
+ '#$hosts))))))))))
(define certbot-activation
(match-lambda
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
2017-12-16 19:18 [bug#29739] [PATCH] services: certbot: Fix certbot renewal job Christopher Baines
@ 2017-12-17 16:10 ` Ludovic Courtès
2017-12-17 20:52 ` bug#29739: " Christopher Baines
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2017-12-17 16:10 UTC (permalink / raw)
To: Christopher Baines; +Cc: 29739
Christopher Baines <mail@cbaines.net> skribis:
> Quote the list of hosts, to avoid generating a broken job definition.
>
> * gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
> passing them in to the job gexp.
Good catch, LGTM!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#29739: [PATCH] services: certbot: Fix certbot renewal job.
2017-12-17 16:10 ` Ludovic Courtès
@ 2017-12-17 20:52 ` Christopher Baines
0 siblings, 0 replies; 3+ messages in thread
From: Christopher Baines @ 2017-12-17 20:52 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 29739-done
[-- Attachment #1: Type: text/plain, Size: 374 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Quote the list of hosts, to avoid generating a broken job definition.
>>
>> * gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
>> passing them in to the job gexp.
>
> Good catch, LGTM!
Great, I've now pushed this :)
Thanks for reviewing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-17 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-16 19:18 [bug#29739] [PATCH] services: certbot: Fix certbot renewal job Christopher Baines
2017-12-17 16:10 ` Ludovic Courtès
2017-12-17 20:52 ` bug#29739: " Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).