unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jovany Leandro G.C" <bit4bit@riseup.net>
Cc: 34634@debbugs.gnu.org
Subject: [bug#34634] [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.
Date: Mon, 11 Mar 2019 23:15:39 +0100	[thread overview]
Message-ID: <87r2bdrras.fsf@gnu.org> (raw)
In-Reply-To: <20190223140939.54371269@riseup.net> (Jovany Leandro G. C.'s message of "Sat, 23 Feb 2019 14:09:39 -0500")

Hi Jovany,

Your email client mangled the patch.  In the future could you send
patches as attachments or use ‘git send-email’?

"Jovany Leandro G.C" <bit4bit@riseup.net> skribis:

> From 693d00d1df68ada3bb43cbaecdd2823976e87bd4 Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <bit4bit@riseup.net>
> Date: Sat, 23 Feb 2019 14:08:01 -0500
> Subject: [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.
>
> * gnu/packages/tryton.scm (tryton-5): New variable.

Do you think we should keep both version 4 and version 5?  Is it
generally useful today to have these two versions available?

> +(define-public tryton-5
> +  (package
> +    (name "tryton")
> +    (version "5.0.6")

Should it inherit from ‘tryton’?

> +    (arguments
> +     `(;;_XSERVTransmkdir: ERROR: euid != 0,directory /tmp/.X11-unix
> will not be created.
> +       #:tests? #f

Could you try adding a phase before ‘check’ that spawns Xvfb?  There are
several examples of this.

> +    (license license:gpl3)))

Version 3 only, or version 3 “or any later version”?

Could you send an updated patch?

Thank you,
Ludo’.

  reply	other threads:[~2019-03-11 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 19:09 [bug#34634] [PATCH 1/1] gnu: tryton: Add tryton 5.0.6 Jovany Leandro G.C
2019-03-11 22:15 ` Ludovic Courtès [this message]
     [not found]   ` <20190312165842.1dc6b8cf@riseup.net>
2019-03-13 10:31     ` Ludovic Courtès
2020-09-05 20:52 ` bug#34634: Closing Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2bdrras.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=34634@debbugs.gnu.org \
    --cc=bit4bit@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).