From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([209.51.188.92]:38046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3TDI-0006Rz-IC
	for guix-patches@gnu.org; Mon, 11 Mar 2019 18:16:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3TDG-000842-TZ
	for guix-patches@gnu.org; Mon, 11 Mar 2019 18:16:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:54265)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1h3TDF-000830-Vf
	for guix-patches@gnu.org; Mon, 11 Mar 2019 18:16:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1h3TDF-0006j8-Nb
	for guix-patches@gnu.org; Mon, 11 Mar 2019 18:16:01 -0400
Subject: [bug#34634] [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.
Resent-Message-ID: <handler.34634.B34634.155234255025835@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20190223140939.54371269@riseup.net>
Date: Mon, 11 Mar 2019 23:15:39 +0100
In-Reply-To: <20190223140939.54371269@riseup.net> (Jovany Leandro G. C.'s
	message of "Sat, 23 Feb 2019 14:09:39 -0500")
Message-ID: <87r2bdrras.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: "Jovany Leandro G.C" <bit4bit@riseup.net>
Cc: 34634@debbugs.gnu.org

Hi Jovany,

Your email client mangled the patch.  In the future could you send
patches as attachments or use =E2=80=98git send-email=E2=80=99?

"Jovany Leandro G.C" <bit4bit@riseup.net> skribis:

> From 693d00d1df68ada3bb43cbaecdd2823976e87bd4 Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <bit4bit@riseup.net>
> Date: Sat, 23 Feb 2019 14:08:01 -0500
> Subject: [PATCH 1/1] gnu: tryton: Add tryton 5.0.6.
>
> * gnu/packages/tryton.scm (tryton-5): New variable.

Do you think we should keep both version 4 and version 5?  Is it
generally useful today to have these two versions available?

> +(define-public tryton-5
> +  (package
> +    (name "tryton")
> +    (version "5.0.6")

Should it inherit from =E2=80=98tryton=E2=80=99?

> +    (arguments
> +     `(;;_XSERVTransmkdir: ERROR: euid !=3D 0,directory /tmp/.X11-unix
> will not be created.
> +       #:tests? #f

Could you try adding a phase before =E2=80=98check=E2=80=99 that spawns Xvf=
b?  There are
several examples of this.

> +    (license license:gpl3)))

Version 3 only, or version 3 =E2=80=9Cor any later version=E2=80=9D?

Could you send an updated patch?

Thank you,
Ludo=E2=80=99.