From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40955@debbugs.gnu.org
Subject: [bug#40955] [PATCH 3/5] build: bootloader: Add install-efi procedure.
Date: Sat, 02 May 2020 14:16:13 +0200 [thread overview]
Message-ID: <87r1w2a5wy.fsf@gnu.org> (raw)
In-Reply-To: <20200429084756.25072-3-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Wed, 29 Apr 2020 10:47:54 +0200")
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> * gnu/build/bootloader.scm (install-efi-loader): New exported procedure. This
> is based on install-efi from (gnu build vm) module.
Please mention the two new procedures.
> * gnu/build/vm.scm (initialize-hard-disk): Adapt to use install-efi-loader.
[…]
> +(define (install-efi-loader grub-efi esp)
> + ;; Create a tiny configuration file telling the embedded grub
> + ;; where to load the real thing.
Could you turn that into a docstring mentioning GRUB-EFI and ESP?
> + ;; XXX This is quite fragile, and can prevent the image from booting
> + ;; when there's more than one volume with this label present.
> + ;; Reproducible almost-UUIDs could reduce the risk (not eliminate it).
> + (let ((grub-config "grub.cfg"))
> + (call-with-output-file grub-config
> + (lambda (port)
^
Indentation is off. :-)
> + (format port
> + "insmod part_msdos~@
> + search --set=root --label Guix_image~@
> + configfile /boot/grub/grub.cfg~%")
> + (fsync port)))
You sure we need an ‘fsync’ call here? Perhaps add a comment explaining
why.
Otherwise LGTM!
Ludo’.
next prev parent reply other threads:[~2020-05-02 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 8:38 [bug#40955] [PATCH 0/5] Add new image API Mathieu Othacehe
2020-04-29 8:47 ` [bug#40955] [PATCH 1/5] build: store-copy: Export file-size procedure Mathieu Othacehe
2020-04-29 8:47 ` [bug#40955] [PATCH 2/5] build: install: Ignore chown exceptions Mathieu Othacehe
2020-05-02 11:09 ` Ludovic Courtès
2020-05-05 13:42 ` Mathieu Othacehe
2020-04-29 8:47 ` [bug#40955] [PATCH 3/5] build: bootloader: Add install-efi procedure Mathieu Othacehe
2020-05-02 12:16 ` Ludovic Courtès [this message]
2020-05-05 13:43 ` Mathieu Othacehe
2020-04-29 8:47 ` [bug#40955] [PATCH 4/5] image: Add a new API Mathieu Othacehe
2020-05-02 12:50 ` Ludovic Courtès
2020-05-05 13:52 ` Mathieu Othacehe
2020-05-02 13:02 ` Tobias Geerinckx-Rice via Guix-patches via
2020-05-05 14:12 ` Mathieu Othacehe
2020-04-29 8:47 ` [bug#40955] [PATCH 5/5] vm: Remove obsolete procedures Mathieu Othacehe
2020-05-02 12:52 ` Ludovic Courtès
2020-05-05 14:02 ` Mathieu Othacehe
2020-05-05 14:16 ` bug#40955: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1w2a5wy.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40955@debbugs.gnu.org \
--cc=m.othacehe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).