From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uO1QHb1krV7RWwAA0tVLHw (envelope-from ) for ; Sat, 02 May 2020 12:17:01 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oIAvN8ZkrV4XEQAA1q6Kng (envelope-from ) for ; Sat, 02 May 2020 12:17:10 +0000 Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:470:142::17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE439940E42 for ; Sat, 2 May 2020 12:17:09 +0000 (UTC) Received: from localhost ([::1]:37410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUr4w-00055t-3z for larch@yhetil.org; Sat, 02 May 2020 08:17:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUr4o-00054S-Uj for guix-patches@gnu.org; Sat, 02 May 2020 08:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUr4o-0006F6-F5 for guix-patches@gnu.org; Sat, 02 May 2020 08:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUr4o-0006Df-2B for guix-patches@gnu.org; Sat, 02 May 2020 08:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jUr4n-0000pm-Ud for guix-patches@gnu.org; Sat, 02 May 2020 08:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40955] [PATCH 3/5] build: bootloader: Add install-efi procedure. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 May 2020 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 40955@debbugs.gnu.org Received: via spool by 40955-submit@debbugs.gnu.org id=B40955.15884217843157 (code B ref 40955); Sat, 02 May 2020 12:17:01 +0000 Received: (at 40955) by debbugs.gnu.org; 2 May 2020 12:16:24 +0000 Received: from localhost ([127.0.0.1]:51479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUr4C-0000or-8q for submit@debbugs.gnu.org; Sat, 02 May 2020 08:16:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUr4A-0000oe-9B for 40955@debbugs.gnu.org; Sat, 02 May 2020 08:16:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56162) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUr45-0003IF-1F; Sat, 02 May 2020 08:16:17 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45086 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jUr43-0008IY-Db; Sat, 02 May 2020 08:16:15 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200429084756.25072-1-m.othacehe@gmail.com> <20200429084756.25072-3-m.othacehe@gmail.com> Date: Sat, 02 May 2020 14:16:13 +0200 In-Reply-To: <20200429084756.25072-3-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Wed, 29 Apr 2020 10:47:54 +0200") Message-ID: <87r1w2a5wy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 2001:470:142::17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.49497699199935]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:142::/48:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.15), country: US(-0.00), ip: 2001:470:142::17(-0.49)]; DWL_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_FAIL(0.00)[2001:470:142::17:server fail]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:2001:470:142::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; FROM_NEQ_ENVFROM(0.00)[ludo@gnu.org,guix-patches-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[gnu.org]; HAS_LIST_UNSUB(-0.01)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_SEVEN(0.00)[10]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: rdnXX5zDVHsC Mathieu Othacehe skribis: > * gnu/build/bootloader.scm (install-efi-loader): New exported procedure. = This > is based on install-efi from (gnu build vm) module. Please mention the two new procedures. > * gnu/build/vm.scm (initialize-hard-disk): Adapt to use install-efi-loade= r. [=E2=80=A6] > +(define (install-efi-loader grub-efi esp) > + ;; Create a tiny configuration file telling the embedded grub > + ;; where to load the real thing. Could you turn that into a docstring mentioning GRUB-EFI and ESP? > + ;; XXX This is quite fragile, and can prevent the image from booting > + ;; when there's more than one volume with this label present. > + ;; Reproducible almost-UUIDs could reduce the risk (not eliminate it). > + (let ((grub-config "grub.cfg")) > + (call-with-output-file grub-config > + (lambda (port) ^ Indentation is off. :-) > + (format port > + "insmod part_msdos~@ > + search --set=3Droot --label Guix_image~@ > + configfile /boot/grub/grub.cfg~%") > + (fsync port))) You sure we need an =E2=80=98fsync=E2=80=99 call here? Perhaps add a comme= nt explaining why. Otherwise LGTM! Ludo=E2=80=99.