* [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
@ 2020-06-02 13:20 Brice Waegeneire
2020-06-11 17:08 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Brice Waegeneire @ 2020-06-02 13:20 UTC (permalink / raw)
To: 41662
* gnu/packages/shells.scm (zsh)[arguments]: Add configure-flags
'disable-site-dir' and 'enable-additional-fpath'.
---
gnu/packages/shells.scm | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/shells.scm b/gnu/packages/shells.scm
index 74d08e02bc..250c6d5576 100644
--- a/gnu/packages/shells.scm
+++ b/gnu/packages/shells.scm
@@ -441,8 +441,16 @@ history mechanism, job control and a C-like syntax.")
(base32
"09yyaadq738zlrnlh1hd3ycj1mv3q5hh4xl1ank70mjnqm6bbi6w"))))
(build-system gnu-build-system)
- (arguments `(#:configure-flags '("--with-tcsetpgrp" "--enable-pcre"
- "--enable-maildir-support")
+ (arguments `(#:configure-flags
+ `("--with-tcsetpgrp"
+ "--enable-pcre"
+ "--enable-maildir-support"
+ ;; share/zsh/site-functions isn't populated
+ "--disable-site-fndir"
+ ,(string-append
+ "--enable-additional-fpath="
+ "/usr/local/share/zsh/site-functions," ; for foreign OS
+ "/run/current-system/profile/share/zsh/site-functions"))
#:phases
(modify-phases %standard-phases
(add-before 'configure 'fix-sh
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
2020-06-02 13:20 [bug#41662] [PATCH] gnu: zsh: Set default '$fpath' Brice Waegeneire
@ 2020-06-11 17:08 ` Ludovic Courtès
2020-06-11 18:36 ` Brice Waegeneire
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2020-06-11 17:08 UTC (permalink / raw)
To: Brice Waegeneire; +Cc: 41662
Hi,
Brice Waegeneire <brice@waegenei.re> skribis:
> * gnu/packages/shells.scm (zsh)[arguments]: Add configure-flags
> 'disable-site-dir' and 'enable-additional-fpath'.
[...]
> + ,(string-append
> + "--enable-additional-fpath="
> + "/usr/local/share/zsh/site-functions," ; for foreign OS
> + "/run/current-system/profile/share/zsh/site-functions"))
/usr/local seems arbitrary. What if we omit it, will that break zsh on
foreign distros?
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
2020-06-11 17:08 ` Ludovic Courtès
@ 2020-06-11 18:36 ` Brice Waegeneire
2020-06-12 14:46 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Brice Waegeneire @ 2020-06-11 18:36 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 41662
Hello Ludo',
On 2020-06-11 17:08, Ludovic Courtès wrote:
>> + ,(string-append
>> + "--enable-additional-fpath="
>> + "/usr/local/share/zsh/site-functions," ; for
>> foreign OS
>> +
>> "/run/current-system/profile/share/zsh/site-functions"))
>
> /usr/local seems arbitrary. What if we omit it, will that break zsh on
> foreign distros?
I let it there because it's a default[0] and because it was already
present
in our current zsh package, you can test that with “zsh -df -c 'echo
$fpath'”.
If I remember correctly I put it there for people using foreign OS who
still
wants some zsh functions from their host OS.
[0]: https://github.com/zsh-users/zsh/blob/master/NEWS#L415-L424
- Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#41662] [PATCH] gnu: zsh: Set default '$fpath'.
2020-06-11 18:36 ` Brice Waegeneire
@ 2020-06-12 14:46 ` Ludovic Courtès
2020-06-14 13:33 ` bug#41662: " Brice Waegeneire
0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2020-06-12 14:46 UTC (permalink / raw)
To: Brice Waegeneire; +Cc: 41662
Hi,
Brice Waegeneire <brice@waegenei.re> skribis:
> On 2020-06-11 17:08, Ludovic Courtès wrote:
>>> + ,(string-append
>>> + "--enable-additional-fpath="
>>> + "/usr/local/share/zsh/site-functions," ; for
>>> foreign OS
>>> +
>>> "/run/current-system/profile/share/zsh/site-functions"))
>>
>> /usr/local seems arbitrary. What if we omit it, will that break zsh on
>> foreign distros?
>
> I let it there because it's a default[0] and because it was already
> present
> in our current zsh package, you can test that with “zsh -df -c 'echo
> $fpath'”.
OK, that makes sense to me.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41662: [PATCH] gnu: zsh: Set default '$fpath'.
2020-06-12 14:46 ` Ludovic Courtès
@ 2020-06-14 13:33 ` Brice Waegeneire
0 siblings, 0 replies; 5+ messages in thread
From: Brice Waegeneire @ 2020-06-14 13:33 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 41662-done
Ludovic Courtès <ludo@gnu.org> writes:
> Brice Waegeneire <brice@waegenei.re> skribis:
>
>> On 2020-06-11 17:08, Ludovic Courtès wrote:
>>>> + ,(string-append
>>>> + "--enable-additional-fpath="
>>>> + "/usr/local/share/zsh/site-functions," ; for
>>>> foreign OS
>>>> +
>>>> "/run/current-system/profile/share/zsh/site-functions"))
>>>
>>> /usr/local seems arbitrary. What if we omit it, will that break zsh on
>>> foreign distros?
>>
>> I let it there because it's a default[0] and because it was already
>> present
>> in our current zsh package, you can test that with “zsh -df -c 'echo
>> $fpath'”.
>
> OK, that makes sense to me.
Pushed as 4f6e6c0442368ac3fd7e95f1fc264671d9182c00.
- Brice
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-14 13:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 13:20 [bug#41662] [PATCH] gnu: zsh: Set default '$fpath' Brice Waegeneire
2020-06-11 17:08 ` Ludovic Courtès
2020-06-11 18:36 ` Brice Waegeneire
2020-06-12 14:46 ` Ludovic Courtès
2020-06-14 13:33 ` bug#41662: " Brice Waegeneire
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).