* [bug#47663] [PATCH] website: Add Help dropdown menu
@ 2021-04-08 19:49 Luis Felipe via Guix-patches via
2021-04-09 6:51 ` Mathieu Othacehe
0 siblings, 1 reply; 8+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-04-08 19:49 UTC (permalink / raw)
To: 47663
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
Hi,
This patch converts the Help item of the navigation bar into a dropdown menu as proposed in the thread "Document our WIP" (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).
---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-website-Add-Help-dropdown-menu.patch --]
[-- Type: text/x-patch; name=0001-website-Add-Help-dropdown-menu.patch, Size: 3641 bytes --]
From dad14c86f4feee4a5e41748db4935870afe15e43 Mon Sep 17 00:00:00 2001
From: Luis Felipe <luis.felipe.la@protonmail.com>
Date: Thu, 8 Apr 2021 14:34:37 -0500
Subject: [PATCH] website: Add Help dropdown menu.
This change converts the Help item of the primary navigation of the
website into a dropdown menu listing the items currently available in
the Help page.
This was proposed in the thread "Document our WIP" sent to the
guix-devel mailing list on March 27, 2021.
* website/apps/base/templates/components.scm (navbar): Make Help a dropdown.
---
website/apps/base/templates/components.scm | 40 +++++++++++++++++++++-
1 file changed, 39 insertions(+), 1 deletion(-)
diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index 7ca76cc..c965d41 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -405,7 +405,45 @@ manual.
(menu-item #:label "Latest"
#:active-item active-item
#:url (guix-url "download/latest/")))))
- ,(C_ "website menu" (menu-item #:label "Help" #:active-item active-item #:url (guix-url "help/")))
+
+ ,(menu-dropdown #:label (C_ "website menu" "Help")
+ #:active-item active-item
+ #:items
+ (list
+ (C_ "website menu"
+ (menu-item #:label "GNU Guix Manual"
+ #:active-item active-item
+ #:url (guix-url "manual/")))
+ (C_ "website menu"
+ (menu-item #:label "Guix Reference Card"
+ #:active-item active-item
+ #:url (guix-url "guix-refcard.pdf")))
+ (C_ "website menu"
+ (menu-item #:label "Videos"
+ #:active-item active-item
+ #:url (guix-url "videos/")))
+ (C_ "website menu"
+ (menu-item #:label "Cookbook"
+ #:active-item active-item
+ #:url (guix-url "cookbook/")))
+ (C_ "website menu"
+ (menu-item #:label "GNU Manuals"
+ #:active-item active-item
+ #:url (gnu-url "manual/")))
+ (C_ "website menu"
+ (menu-item #:label "Wiki"
+ #:active-item active-item
+ #:url (identity "https://libreplanet.org/wiki/Group:Guix")))
+ (C_ "website menu"
+ (menu-item #:label "IRC Chat"
+ #:active-item active-item
+ #:url (guix-url "contact/irc/")))
+ (C_ "website menu"
+ (menu-item #:label "Mailing Lists"
+ #:active-item active-item
+ #:url (guix-url "contact/")))))
+
+
,(C_ "website menu" (menu-item #:label "Packages" #:active-item active-item #:url (guix-url "packages/")))
,(C_ "website menu" (menu-item #:label "Blog" #:active-item active-item #:url (guix-url "blog/")))
base-commit: c46cc7d80a1e90d3d841e5b59f6e131bf2052c87
--
2.31.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-08 19:49 [bug#47663] [PATCH] website: Add Help dropdown menu Luis Felipe via Guix-patches via
@ 2021-04-09 6:51 ` Mathieu Othacehe
2021-04-09 13:32 ` Luis Felipe via Guix-patches via
0 siblings, 1 reply; 8+ messages in thread
From: Mathieu Othacehe @ 2021-04-09 6:51 UTC (permalink / raw)
To: Luis Felipe; +Cc: 47663
Hello Luis,
> This patch converts the Help item of the navigation bar into a dropdown menu
> as proposed in the thread "Document our WIP"
> (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).
I find that this new dropdown provides an easier access to the Help
links which is nice!
What do we do with the old help/index.html page, that is now not
accessible? Maybe we need to remove this file:
artwork/website/apps/base/templates/help.scm?
Also I noticed that left clicking directly on the "Help" menu causes
some undesired wrapping on the Help items.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-09 6:51 ` Mathieu Othacehe
@ 2021-04-09 13:32 ` Luis Felipe via Guix-patches via
2021-04-09 18:55 ` Mathieu Othacehe
0 siblings, 1 reply; 8+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-04-09 13:32 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 47663@debbugs.gnu.org
Hey Mathieu,
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, April 9, 2021 6:51 AM, Mathieu Othacehe <othacehe@gnu.org> wrote:
> Hello Luis,
>
> > This patch converts the Help item of the navigation bar into a dropdown menu
> > as proposed in the thread "Document our WIP"
> > (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).
>
> I find that this new dropdown provides an easier access to the Help
> links which is nice!
>
> What do we do with the old help/index.html page, that is now not
> accessible? Maybe we need to remove this file:
> artwork/website/apps/base/templates/help.scm?
Oh, I completely forgot about that, and I'd actually like to keep that page and link to it from the menu too. So let me think how to solve that.
> Also I noticed that left clicking directly on the "Help" menu causes
> some undesired wrapping on the Help items.
I'll take a look at this too, and send another patch.
Thanks for your help so far, Mathieu.
Best,
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-09 13:32 ` Luis Felipe via Guix-patches via
@ 2021-04-09 18:55 ` Mathieu Othacehe
2021-04-09 19:12 ` pelzflorian (Florian Pelz)
0 siblings, 1 reply; 8+ messages in thread
From: Mathieu Othacehe @ 2021-04-09 18:55 UTC (permalink / raw)
To: Luis Felipe; +Cc: 47663@debbugs.gnu.org
Hey Luis,
> Oh, I completely forgot about that, and I'd actually like to keep that page and link to it from the menu too. So let me think how to solve that.
Yes keeping it is fine to me. At first I thought that left clicking the
"Help" menu would open it. Adding a dedicated item in the list also
seems fine.
> I'll take a look at this too, and send another patch.
Great :)
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-09 18:55 ` Mathieu Othacehe
@ 2021-04-09 19:12 ` pelzflorian (Florian Pelz)
2021-04-09 19:51 ` Luis Felipe via Guix-patches via
0 siblings, 1 reply; 8+ messages in thread
From: pelzflorian (Florian Pelz) @ 2021-04-09 19:12 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: Luis Felipe, 47663@debbugs.gnu.org
Thank you for working on this.
On Fri, Apr 09, 2021 at 08:55:50PM +0200, Mathieu Othacehe wrote:
> At first I thought that left clicking the
> "Help" menu would open it. Adding a dedicated item in the list also
> seems fine.
In commit 571e1a416e1148139923418bf801ddb6b11723c3 I made left-click
toggle the dropdown instead because touch devices cannot otherwise
access the dropdown, I think. Am I mistaken?
Regards,
Florian
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-09 19:12 ` pelzflorian (Florian Pelz)
@ 2021-04-09 19:51 ` Luis Felipe via Guix-patches via
2021-04-10 15:24 ` Luis Felipe via Guix-patches via
0 siblings, 1 reply; 8+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-04-09 19:51 UTC (permalink / raw)
To: pelzflorian (Florian Pelz); +Cc: Mathieu Othacehe, 47663@debbugs.gnu.org
On Friday, April 9, 2021 7:12 PM, pelzflorian (Florian Pelz) <pelzflorian@pelzflorian.de> wrote:
> Thank you for working on this.
>
> On Fri, Apr 09, 2021 at 08:55:50PM +0200, Mathieu Othacehe wrote:
>
> > At first I thought that left clicking the
> > "Help" menu would open it. Adding a dedicated item in the list also
> > seems fine.
>
> In commit 571e1a416e1148139923418bf801ddb6b11723c3 I made left-click
> toggle the dropdown instead because touch devices cannot otherwise
> access the dropdown, I think. Am I mistaken?
I think that is the right behavior, Florian. So I'll add the missing link as a new item, like so:
Help
+ All ← Links to /help/
+ Etc.
+ Etc.
And fix any remaining style issues for pointing and touch devices (cursor shouldn't be pointer (it wasn't before), and dropdown menu width should not shrink on click).
^ permalink raw reply [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-09 19:51 ` Luis Felipe via Guix-patches via
@ 2021-04-10 15:24 ` Luis Felipe via Guix-patches via
2021-04-10 18:51 ` Mathieu Othacehe
0 siblings, 1 reply; 8+ messages in thread
From: Luis Felipe via Guix-patches via @ 2021-04-10 15:24 UTC (permalink / raw)
To: pelzflorian (Florian Pelz); +Cc: Mathieu Othacehe, 47663@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 581 bytes --]
On Friday, April 9, 2021 7:51 PM, Luis Felipe <luis.felipe.la@protonmail.com> wrote:
> I think that is the right behavior, Florian. So I'll add the missing link as a new item, like so:
>
> Help
>
> - All ← Links to /help/
> - Etc.
> - Etc.
The attached patched does this.
> And fix any remaining style issues for pointing and touch devices (cursor shouldn't be pointer (it wasn't before), and dropdown menu width should not shrink on click).
>
I'd like to address this separately, so I'll file a new issue and provide a patch once I have something.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-website-Add-Help-dropdown-menu.patch --]
[-- Type: text/x-patch; name=0001-website-Add-Help-dropdown-menu.patch, Size: 3869 bytes --]
From 0666d8ec13d1fd069e4123c0b4ee52289650ab91 Mon Sep 17 00:00:00 2001
From: Luis Felipe <luis.felipe.la@protonmail.com>
Date: Sat, 10 Apr 2021 10:00:51 -0500
Subject: [PATCH] website: Add Help dropdown menu.
This change converts the Help item of the primary navigation of
the website into a dropdown menu listing the items currently available
in the Help page.
This was proposed in the thread "Document our WIP" sent to
the guix-devel mailing list on March 27, 2021.
* website/apps/base/templates/components.scm (navbar): Make Help a dropdown.
---
website/apps/base/templates/components.scm | 44 +++++++++++++++++++++-
1 file changed, 43 insertions(+), 1 deletion(-)
diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index 7ca76cc..6ead1e5 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -405,7 +405,49 @@ manual.
(menu-item #:label "Latest"
#:active-item active-item
#:url (guix-url "download/latest/")))))
- ,(C_ "website menu" (menu-item #:label "Help" #:active-item active-item #:url (guix-url "help/")))
+
+ ,(menu-dropdown #:label (C_ "website menu" "Help")
+ #:active-item active-item
+ #:items
+ (list
+ (C_ "website menu"
+ (menu-item #:label "All"
+ #:active-item active-item
+ #:url (guix-url "help/")))
+ (C_ "website menu"
+ (menu-item #:label "GNU Guix Manual"
+ #:active-item active-item
+ #:url (guix-url "manual/")))
+ (C_ "website menu"
+ (menu-item #:label "Guix Reference Card"
+ #:active-item active-item
+ #:url (guix-url "guix-refcard.pdf")))
+ (C_ "website menu"
+ (menu-item #:label "Videos"
+ #:active-item active-item
+ #:url (guix-url "videos/")))
+ (C_ "website menu"
+ (menu-item #:label "Cookbook"
+ #:active-item active-item
+ #:url (guix-url "cookbook/")))
+ (C_ "website menu"
+ (menu-item #:label "GNU Manuals"
+ #:active-item active-item
+ #:url (gnu-url "manual/")))
+ (C_ "website menu"
+ (menu-item #:label "Wiki"
+ #:active-item active-item
+ #:url (identity "https://libreplanet.org/wiki/Group:Guix")))
+ (C_ "website menu"
+ (menu-item #:label "IRC Chat"
+ #:active-item active-item
+ #:url (guix-url "contact/irc/")))
+ (C_ "website menu"
+ (menu-item #:label "Mailing Lists"
+ #:active-item active-item
+ #:url (guix-url "contact/")))))
+
+
,(C_ "website menu" (menu-item #:label "Packages" #:active-item active-item #:url (guix-url "packages/")))
,(C_ "website menu" (menu-item #:label "Blog" #:active-item active-item #:url (guix-url "blog/")))
base-commit: 3c7adcaa80a7e2f4af90b6d629beed46276d66af
--
2.31.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [bug#47663] [PATCH] website: Add Help dropdown menu
2021-04-10 15:24 ` Luis Felipe via Guix-patches via
@ 2021-04-10 18:51 ` Mathieu Othacehe
0 siblings, 0 replies; 8+ messages in thread
From: Mathieu Othacehe @ 2021-04-10 18:51 UTC (permalink / raw)
To: 47663; +Cc: Luis Felipe, pelzflorian (Florian Pelz), 47663-done
Hello,
> I'd like to address this separately, so I'll file a new issue and provide a patch once I have something.
Fine, pushed this one as 321813e88f06e1743c75a1a3b7fe9a0705514a80.
Thanks,
Mathieu
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-04-10 18:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 19:49 [bug#47663] [PATCH] website: Add Help dropdown menu Luis Felipe via Guix-patches via
2021-04-09 6:51 ` Mathieu Othacehe
2021-04-09 13:32 ` Luis Felipe via Guix-patches via
2021-04-09 18:55 ` Mathieu Othacehe
2021-04-09 19:12 ` pelzflorian (Florian Pelz)
2021-04-09 19:51 ` Luis Felipe via Guix-patches via
2021-04-10 15:24 ` Luis Felipe via Guix-patches via
2021-04-10 18:51 ` Mathieu Othacehe
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).