From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 路辉 <luhux76@gmail.com>
Cc: 53319@debbugs.gnu.org
Subject: [bug#53319] [PATCH] gnu: Add n2n.
Date: Fri, 28 Jan 2022 11:10:14 +0100 [thread overview]
Message-ID: <87r18stbll.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAGNyvehn=j+kGhwQ-8E0qOocfdYUDvnXU0tCYnaB2v9847QuLQ@mail.gmail.com> ("路辉"'s message of "Mon, 17 Jan 2022 14:47:36 +0000")
Hello,
路辉 <luhux76@gmail.com> writes:
> Subject: [PATCH] gnu: Add n2n.
Thank you. Some comments follow.
> +(define-public n2n-2
I think the variable should be "n2n" only.
> + (native-inputs (list autoconf automake))
> + (arguments
> + `(#:make-flags (list (string-append "PREFIX=" %output) "CC=gcc")
CC=gcc is not cross-compilation friendly. Also, %output is being phased
out. I suggest using G-expressions:
(arguments
(list
#:make-flags
#~(list (string-append "PREFIX=" #$output)
#$(string-append "CC=" (cc-for-target)))
...))
> + #:phases
> + (modify-phases %standard-phases
If you use G-expressions, you'll need to start with:
#~(modify-phases %standard-phases
...)
> + (add-before 'configure 'fix-configure
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "configure"
> + (("/bin/sh") (which "sh"))))))
Instead of using `which', you can use `search-input-file':
(("/bin/sh") (search-input-file inputs "/bin/sh"))
> + #:tests? #f)) ;there is no check target
> + (home-page "https://github.com/ntop/n2n")
> + (synopsis "Peer-to-peer VPN client and server")
> + (description
> + "A light VPN software which makes it
> +easy to create virtual networks bypassing intermediate firewalls.")
Description should consist of full sentences. I suggest:
n2n is a light VPN software which makes it easy to create virtual
networks bypassing intermediate firewalls.
Also, the package brings third-party software: libnatpmp and libupnp.
Would it be possible to unbundle them, since Guix already ships both?
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-01-28 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 14:47 [bug#53319] [PATCH] gnu: Add n2n 路辉
2022-01-28 10:10 ` Nicolas Goaziou [this message]
2022-02-22 11:36 ` Maxime Devos
2022-02-22 18:49 ` Nicolas Goaziou
2022-03-20 12:20 ` 路辉
2022-02-22 11:20 ` bug#53319: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r18stbll.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53319@debbugs.gnu.org \
--cc=luhux76@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).