From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6FyBKkTB82GuJAEAgWs5BA (envelope-from ) for ; Fri, 28 Jan 2022 11:11:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id CA3XJ0TB82FFQwEA9RJhRA (envelope-from ) for ; Fri, 28 Jan 2022 11:11:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CAE637ABF for ; Fri, 28 Jan 2022 11:11:16 +0100 (CET) Received: from localhost ([::1]:60424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDODr-0001eC-4l for larch@yhetil.org; Fri, 28 Jan 2022 05:11:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDODf-0001db-9V for guix-patches@gnu.org; Fri, 28 Jan 2022 05:11:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36355) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nDODe-0005Hm-FO for guix-patches@gnu.org; Fri, 28 Jan 2022 05:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nDODe-00037k-CN for guix-patches@gnu.org; Fri, 28 Jan 2022 05:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53319] [PATCH] gnu: Add n2n. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 28 Jan 2022 10:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Cc: 53319@debbugs.gnu.org Received: via spool by 53319-submit@debbugs.gnu.org id=B53319.164336462511950 (code B ref 53319); Fri, 28 Jan 2022 10:11:02 +0000 Received: (at 53319) by debbugs.gnu.org; 28 Jan 2022 10:10:25 +0000 Received: from localhost ([127.0.0.1]:57491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDOD3-00036g-1C for submit@debbugs.gnu.org; Fri, 28 Jan 2022 05:10:25 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nDOD0-00036O-SI for 53319@debbugs.gnu.org; Fri, 28 Jan 2022 05:10:23 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id F12FBC0002; Fri, 28 Jan 2022 10:10:15 +0000 (UTC) From: Nicolas Goaziou References: Date: Fri, 28 Jan 2022 11:10:14 +0100 In-Reply-To: ("=?UTF-8?Q?=E8=B7=AF=E8=BE=89?="'s message of "Mon, 17 Jan 2022 14:47:36 +0000") Message-ID: <87r18stbll.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643364676; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=ohA+0OxVsFDC0EUdhqY2jFgN/RMfd0JUbAbjp9538n8=; b=u2g/IG9Rb4pzh+RuSAYbXaZx3JY1H4fbOU46A4bNMCelXulaEmBtMNiTtx/Xs8WV33Ht9i arESKugWA/7VVLqw4aL8fwTOYJV+IU6n8eixQHhNiR+lZ//omCQ6alZzCOKo9LiI+ubjlG y4MFd1geRiWgYUhLUn6/HQxX4jqQJ3qF9l7Zrqh7QJ2RGPJgh0d3NKgXaINmqCHBk2B20a 4+lKyIDdAfcZCAWZxMV6QmVUVB49JNucRY9U3tVwUnSsJlryWPpcLMDHd77y6sgnoiyAUD iDxoj3TyLkmsmSbwYUArLRKiQ9dsuNCelI4v9FM9RMRw7SOtgJFs858wd+ME+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643364676; a=rsa-sha256; cv=none; b=OEOFB2XUql1wckt47fgUP7TyKSPEqKfXHI6+RHlLP5KHQP4p9b/wMV46WN8P2nd1AthYYp a4tdn5vv2CP7EQ9JsU66GWKIAkHS6txJgQbd8ThFZ2fMm6fkAqR1fqnUFPO6shGDen+E8X Qs1d4g4OLrrPRv8ItGkB7nxpe8rTF2yc9pNvw2cyEZtl3izSpOMnFfxPurTHNI/+8mzKLx nh+chscOCxMLA9Tx9jmhEYDLE9cGxdf2FcYa8QhEZgS3pCJpUns9NPjQHRbVIj/pEpeUmm nTAL7Kt1FvEH4RxqKq33eR12KEpZxFloW0NExcOlkwG5sRe1ClJC9BgfKzJYcA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.93 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4CAE637ABF X-Spam-Score: -3.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: 8Yqb9CPKkvIV Hello, =E8=B7=AF=E8=BE=89 writes: > Subject: [PATCH] gnu: Add n2n. Thank you. Some comments follow. > +(define-public n2n-2 I think the variable should be "n2n" only. > + (native-inputs (list autoconf automake)) > + (arguments > + `(#:make-flags (list (string-append "PREFIX=3D" %output) "CC=3Dgcc") CC=3Dgcc is not cross-compilation friendly. Also, %output is being phased out. I suggest using G-expressions: (arguments (list #:make-flags #~(list (string-append "PREFIX=3D" #$output) #$(string-append "CC=3D" (cc-for-target))) ...)) > + #:phases > + (modify-phases %standard-phases If you use G-expressions, you'll need to start with: #~(modify-phases %standard-phases ...) > + (add-before 'configure 'fix-configure > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "configure" > + (("/bin/sh") (which "sh")))))) Instead of using `which', you can use `search-input-file': (("/bin/sh") (search-input-file inputs "/bin/sh"))=20=20 > + #:tests? #f)) ;there is no check target > + (home-page "https://github.com/ntop/n2n") > + (synopsis "Peer-to-peer VPN client and server") > + (description > + "A light VPN software which makes it > +easy to create virtual networks bypassing intermediate firewalls.") Description should consist of full sentences. I suggest: n2n is a light VPN software which makes it easy to create virtual networks bypassing intermediate firewalls. Also, the package brings third-party software: libnatpmp and libupnp. Would it be possible to unbundle them, since Guix already ships both? Could you send an updated patch? Regards, --=20 Nicolas Goaziou