* [bug#56387] [PATCH] computed-file: Clarify comment about guile record field.
@ 2022-07-04 20:02 jgart via Guix-patches via
2022-07-07 21:39 ` bug#56387: " Maxim Cournoyer
0 siblings, 1 reply; 2+ messages in thread
From: jgart via Guix-patches via @ 2022-07-04 20:02 UTC (permalink / raw)
To: 56387; +Cc: jgart
* guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
record field is any variant of a guile package record instance.
---
guix/gexp.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/gexp.scm b/guix/gexp.scm
index ef92223048..eba65e92cf 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -581,7 +581,7 @@ (define-record-type <computed-file>
computed-file?
(name computed-file-name) ;string
(gexp computed-file-gexp) ;gexp
- (guile computed-file-guile) ;<package>
+ (guile computed-file-guile) ;<package guile-*>
(options computed-file-options)) ;list of arguments
(define* (computed-file name gexp
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#56387: [PATCH] computed-file: Clarify comment about guile record field.
2022-07-04 20:02 [bug#56387] [PATCH] computed-file: Clarify comment about guile record field jgart via Guix-patches via
@ 2022-07-07 21:39 ` Maxim Cournoyer
0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2022-07-07 21:39 UTC (permalink / raw)
To: jgart; +Cc: 56387-done
Hi jgart,
jgart <jgart@dismail.de> writes:
> * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile
> record field is any variant of a guile package record instance.
> ---
> guix/gexp.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guix/gexp.scm b/guix/gexp.scm
> index ef92223048..eba65e92cf 100644
> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -581,7 +581,7 @@ (define-record-type <computed-file>
> computed-file?
> (name computed-file-name) ;string
> (gexp computed-file-gexp) ;gexp
> - (guile computed-file-guile) ;<package>
> + (guile computed-file-guile) ;<package guile-*>
> (options computed-file-options)) ;list of arguments
If this was a statically typed language, the proper type of the argument
accepted would be <package>, not <package guile-*>, so I'm inclined to
leave it the way it is (also, we'd have to survey the whole code base to
adjust for our current convention, which is to use <package>).
Closing,
Thanks,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-07 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 20:02 [bug#56387] [PATCH] computed-file: Clarify comment about guile record field jgart via Guix-patches via
2022-07-07 21:39 ` bug#56387: " Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).