From: "Ludovic Courtès" <ludo@gnu.org>
To: Hilton Chain <hako@ultrarare.space>
Cc: 65204@debbugs.gnu.org
Subject: [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher.
Date: Mon, 21 Aug 2023 16:03:27 +0200 [thread overview]
Message-ID: <87r0nwa3ww.fsf_-_@gnu.org> (raw)
In-Reply-To: <5fc910a54b6027a6cdbe7fe2fabf476b73861489.1691666406.git.hako@ultrarare.space> (Hilton Chain's message of "Thu, 10 Aug 2023 19:43:12 +0800")
Hi,
Hilton Chain <hako@ultrarare.space> skribis:
> * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add
> phase 'regenerate-hash.
> [native-inputs]: Add go-github-com-tdewolff-hasher.
[...]
> + (list #:import-path "github.com/tdewolff/parse/v2"
> + #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'regenerate-hash
> + (lambda* (#:key import-path #:allow-other-keys)
> + (for-each
> + (lambda (dir)
> + (with-directory-excursion
> + (format #f "src/~a/~a" import-path dir)
> + (make-file-writable "hash.go")
> + (format #t "Generating `hash.go' for ~a...~%" dir)
> + (invoke "go" "generate")))
Maybe you can remove ‘hash.go’ in a snippet, for good measure, and add a
comment clarifying that it’s a generated file.
Otherwise the patch series LGTM!
Ludo’.
next prev parent reply other threads:[~2023-08-21 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 11:40 [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 1/6] gnu: Add go-github-com-dgryski-go-metro Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 2/6] gnu: Add go-github-com-dgryski-go-mph Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 3/6] gnu: Add go-github-com-cespare-mph Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 4/6] gnu: Add go-github-com-tdewolff-hasher Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 5/6] gnu: go-github-com-tdewolff-parse-v2: Regenerate hash Hilton Chain via Guix-patches via
2023-08-21 14:03 ` Ludovic Courtès [this message]
2023-08-21 15:20 ` [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher Hilton Chain via Guix-patches via
2023-08-10 11:43 ` [bug#65204] [PATCH 6/6] gnu: go-github-com-tdewolff-minify-v2: Regenerate hash Hilton Chain via Guix-patches via
2023-09-06 5:28 ` bug#65204: [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0nwa3ww.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=65204@debbugs.gnu.org \
--cc=hako@ultrarare.space \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).