From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KOlPF5R242TDAgAASxT56A (envelope-from ) for ; Mon, 21 Aug 2023 16:37:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2BwSF5R242T5QgAA9RJhRA (envelope-from ) for ; Mon, 21 Aug 2023 16:37:08 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03DDC4C8E6 for ; Mon, 21 Aug 2023 16:37:08 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="gR8l/m0s"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692628628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FrkMG/0xOJ8PkzNBPTXQGMbceLeFqwbADmpyofOJ5Y4=; b=VH7Ev31ygPIKwA/LuNtN2e6OJ6eSjWvjNlSSnfHqDBMyW7d/94oEW3cUQybkWggbBLuqRC 2z0Zoo1zNsdHnzHxr0FjKK2zGG46BAcWcEHp0Y8ieyiTJslEuIr/ZJuKcGjqvwnlv3h7+m 0LEyI6QWdHQAqdqlvrQfB6LuSHiriLPG7kH7ZHIezNDgPsKNi1dFr61hQWXUqSlC1KgVM5 5PZwu8vQkkAecjyujjTK+TJ93jxD61lWYJTlA1UB8nlwtkZPZtjOYbpm3p5xN0kZ/IoaD/ b0plUR4XX0QkEwnwzwUQ49ze0aeWTXReTzOwRhH+UpmGo85Q4Y6UjVXWpoIoPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692628628; a=rsa-sha256; cv=none; b=thQF/pixQjgBn2hMBVbMUXsmm6C9llY8ww3Yxt5TD9kztu4ODc/5vQnCDAuJJQNokOvmwU e4zqC+urZ9y7GCpVHiJyxPfjQ3DdybZdKEHPyRk5BsSpS95ql0XWjcH8PDEvu2oqQuEfFa BzJobXl2VjvUBUt+VckKvQsJZCc4JR+KdCrca6lHmiuOFFpF4X8F/fZ+caUtwHCKk1ICoj FGZ3OluL3P1KRIR6HX9LOXG8Pyl9rm2a6j6w89wEjLsoJAY9PdHeZI0pxtDKzYUy+QO5+p Rp5Cd+aQoFqDdTGEQVQZy5nRi0rHdo/mK1Q2X9q113JgevKP6CnmwHxFVQzOZg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="gR8l/m0s"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qY5Vm-0004XV-TB; Mon, 21 Aug 2023 10:04:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY5Vg-0004WK-Hk for guix-patches@gnu.org; Mon, 21 Aug 2023 10:04:01 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qY5Vg-0004xR-96 for guix-patches@gnu.org; Mon, 21 Aug 2023 10:04:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qY5Vi-00004y-Di for guix-patches@gnu.org; Mon, 21 Aug 2023 10:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65204] [PATCH 0/6] gnu: Add go-github-com-tdewolff-hasher. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 21 Aug 2023 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain Cc: 65204@debbugs.gnu.org Received: via spool by 65204-submit@debbugs.gnu.org id=B65204.169262662332744 (code B ref 65204); Mon, 21 Aug 2023 14:04:02 +0000 Received: (at 65204) by debbugs.gnu.org; 21 Aug 2023 14:03:43 +0000 Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY5VO-0008W4-UL for submit@debbugs.gnu.org; Mon, 21 Aug 2023 10:03:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qY5VN-0008Vs-9d for 65204@debbugs.gnu.org; Mon, 21 Aug 2023 10:03:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qY5VE-0004tS-E2; Mon, 21 Aug 2023 10:03:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=FrkMG/0xOJ8PkzNBPTXQGMbceLeFqwbADmpyofOJ5Y4=; b=gR8l/m0s56S50wsRPfe5 +BtjORHt9Ym+KwgZatRGdQknBpz3pOWAcGSsTqII0JgegxZ+RbkzfiLniwbquEhF8tFYpBfNo1wva tierndwPl4uzXMWwfHnLNR62WlV3hGXnno6AQfUdz5Is371fiwRWVKAB+Zevud3Z9iXjRY+IjCHx3 MlDCU8YGc+/Mk1q8bFbrOZ4AXI1q08w93QF57XTFK/2rk45vVnFmRG+767Oy3OxKHK9bU5zOk8LZX scUFq1gqmSZRogqu4drOX+KrH6k3w7ejPo93ZOWNVjUEVPIup9rxYF6hlAR48XfWAgYz4qXqrcET5 DAEJ1O18c4H2lQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <5fc910a54b6027a6cdbe7fe2fabf476b73861489.1691666406.git.hako@ultrarare.space> Date: Mon, 21 Aug 2023 16:03:27 +0200 In-Reply-To: <5fc910a54b6027a6cdbe7fe2fabf476b73861489.1691666406.git.hako@ultrarare.space> (Hilton Chain's message of "Thu, 10 Aug 2023 19:43:12 +0800") Message-ID: <87r0nwa3ww.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.90 X-Spam-Score: -6.90 X-Migadu-Queue-Id: 03DDC4C8E6 X-Migadu-Scanner: mx1.migadu.com X-TUID: YqXOQ8YLlvkH Hi, Hilton Chain skribis: > * gnu/packages/golang.scm (go-github-com-tdewolff-parse-v2)[#:phases]: Add > phase 'regenerate-hash. > [native-inputs]: Add go-github-com-tdewolff-hasher. [...] > + (list #:import-path "github.com/tdewolff/parse/v2" > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'regenerate-hash > + (lambda* (#:key import-path #:allow-other-keys) > + (for-each > + (lambda (dir) > + (with-directory-excursion > + (format #f "src/~a/~a" import-path dir) > + (make-file-writable "hash.go") > + (format #t "Generating `hash.go' for ~a...~%" di= r) > + (invoke "go" "generate"))) Maybe you can remove =E2=80=98hash.go=E2=80=99 in a snippet, for good measu= re, and add a comment clarifying that it=E2=80=99s a generated file. Otherwise the patch series LGTM! Ludo=E2=80=99.