unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: Jonathan Brielmaier <jonathan.brielmaier@web.de>, 66408@debbugs.gnu.org
Subject: [bug#66408] [PATCH v5] gnu: icecat: Support Guix packaged extensions and native manifests.
Date: Fri, 20 Oct 2023 14:40:10 +0200	[thread overview]
Message-ID: <87r0lpsc0l.fsf@lassieur.org> (raw)
In-Reply-To: <87h6mllijc.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 20 Oct 2023 12:01:11 +0200")

Hey Mathieu,

>> +              (let* ((id #$(assq-ref properties 'id))
>
> id is maybe a bit generic?

Done.

>> +                     (firefox (in-vicinity (assoc-ref outputs "firefox") id))
>> +                     (xpi (assoc-ref outputs "xpi"))
>> +                     (chromium (assoc-ref outputs "chromium")))
>>                  (install-file "dist/build/uBlock0.firefox.xpi"
>>                                (string-append xpi "/lib/mozilla/extensions"))
>>                  (copy-recursively "dist/build/uBlock0.firefox" firefox)
>> @@ -142,3 +146,6 @@ (define ublock-origin
>>  
>>  (define-public ublock-origin/chromium
>>    (make-chromium-extension ublock-origin "chromium"))
>> +
>> +(define-public ublock-origin/icecat
>> +  (make-icecat-extension ublock-origin "firefox"))
>
> It does not appear clearly that one has to install ublock-origin-icecat
> here. We have the same issue for ublock-origin-chromium though.

Indeed!  That's a small change that should be in another patch I
believe.

>> diff --git a/gnu/packages/patches/icecat-compare-paths.patch b/gnu/packages/patches/icecat-compare-paths.patch
>> new file mode 100644
>> index 000000000000..9205899dc0c4
>> --- /dev/null
>> +++ b/gnu/packages/patches/icecat-compare-paths.patch
>
> You could add a small header explaining the content of that patch, ...

Done.

>> --- /dev/null
>> +++ b/gnu/packages/patches/icecat-use-system-wide-dir.patch
>
> ..., as well as that one.

Done.

> I tried a guix shell icecat ublock-origin-icecat and it worked perfectly
> :) It is also very appreciated to have a pre-built icecat by the QA :).

Thanks for the review!
Clément




  reply	other threads:[~2023-10-20 12:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-08 16:26 [bug#66408] [PATCH] gnu: icecat: Add support for Guix packaged extensions Clément Lassieur
2023-10-08 23:07 ` [bug#66408] [PATCH v2] " Clément Lassieur
2023-10-11 12:26 ` [bug#66408] [PATCH v3] " Clément Lassieur
2023-10-11 14:52   ` Clément Lassieur
2023-10-23  7:37   ` Andrew Tropin
2023-10-17 12:48 ` [bug#66408] [PATCH v4] " Clément Lassieur
2023-10-17 16:45 ` [bug#66408] [PATCH v5] gnu: icecat: Support Guix packaged extensions and native manifests Clément Lassieur
2023-10-20 10:01   ` Mathieu Othacehe
2023-10-20 12:40     ` Clément Lassieur [this message]
2023-10-23  7:14       ` Mathieu Othacehe
2023-10-23  9:55         ` bug#66408: " Clément Lassieur
2023-10-20 12:26 ` [bug#66408] [PATCH v6] " Clément Lassieur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0lpsc0l.fsf@lassieur.org \
    --to=clement@lassieur.org \
    --cc=66408@debbugs.gnu.org \
    --cc=jonathan.brielmaier@web.de \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).