From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qBoqNmB1MmVgJQEAauVa8A:P1 (envelope-from ) for ; Fri, 20 Oct 2023 14:41:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qBoqNmB1MmVgJQEAauVa8A (envelope-from ) for ; Fri, 20 Oct 2023 14:41:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BE7415C704 for ; Fri, 20 Oct 2023 14:41:03 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=ouQpEcbR; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="LCpG7Q/V"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1697805664; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SDZyj5kaO+W34jWN1YiBEhm6U/8Re7fkPDqMiFXCAfI=; b=qI971cumcVJdDmGkT1OCz7h+qQTWLg4ZUVMPdoDT7hXR/2yDzzw5MixhxKsa9bnVhstS5C GtAOjIlzTiPI7A4zJY/0BLC0vTSw/zpJmj4pmm1k87hM1jZ222bXmBQxZTjy1yd0MQDLx0 AIyklIexERlgo6PaVMJ4lBrrP2RC0/3RYBbEuiG48ohASb2R8NCIKGtWP62WZZg/5TVZtF wnUY2YfuESHQvatxNqBgfU1pb2uCRy+Ith3JBG7mnaln8SAq9GllqKzxO5/V+hKXogzEgL 5t7osKmkgB6eDaAOLNfU9A5Nh5mudDKcKkwGjFx79ZRFwk+p8/h4covdxxLgMA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm2 header.b=ouQpEcbR; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b="LCpG7Q/V"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1697805664; a=rsa-sha256; cv=none; b=RHY6EBaPCWCvS1jVrkPHNoNopw+YIyDEH2GqB3kTydG7t6O0D3e+H8+pzwZdzEulgDRCFi gnimskR1eCOAigxpUJSJuz8/hiWFrL+JQHnU7+ITGw4DTP/RO3PNGwo9IJ7meWHm/vr2rt 0KPAZTMJPQKMov1hxyr+4qWU1dclB8zih8YvFN9OQSeZtsXpbvhbUwiu1dQVW18nFPOcBI lhz2M4AQgSrAQRMqiXuUfSkFdgMoC4dYSXv7htEgJwQFNonBwc/l2raGTJf7SpaGwKPPrR Ufw4gxrfOkm7k9jIgj6k3zmQC0UHJvkfktJzyPXCl6W36jumNCtR2oKTuvH+dg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtonu-0008Ct-N1; Fri, 20 Oct 2023 08:40:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtonr-00081v-6w for guix-patches@gnu.org; Fri, 20 Oct 2023 08:40:35 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qtonq-00063J-Qz for guix-patches@gnu.org; Fri, 20 Oct 2023 08:40:34 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qtooH-0003K3-O3 for guix-patches@gnu.org; Fri, 20 Oct 2023 08:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66408] [PATCH v5] gnu: icecat: Support Guix packaged extensions and native manifests. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Oct 2023 12:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66408 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: Jonathan Brielmaier , 66408@debbugs.gnu.org Received: via spool by 66408-submit@debbugs.gnu.org id=B66408.169780565212747 (code B ref 66408); Fri, 20 Oct 2023 12:41:01 +0000 Received: (at 66408) by debbugs.gnu.org; 20 Oct 2023 12:40:52 +0000 Received: from localhost ([127.0.0.1]:38941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtoo8-0003JX-C5 for submit@debbugs.gnu.org; Fri, 20 Oct 2023 08:40:52 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:46443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qtoo2-0003JF-QI for 66408@debbugs.gnu.org; Fri, 20 Oct 2023 08:40:50 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id C9FB132009D8; Fri, 20 Oct 2023 08:40:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 20 Oct 2023 08:40:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1697805613; x=1697892013; bh=SDZyj5kaO+W34jWN1YiBEhm6U/8Re7fkPDq MiFXCAfI=; b=ouQpEcbRLnMyqQ0jec7nzD2Qs+gBhjUCQDl+1+RlTY3a0LcOaIh OoYgGIZ+ZKvBXtxo8I8cN+mmIKfTI74u69H9VyNANqXzACmJNHLNKNB4rlwEabvN B8Eztm0/Xz0CPg+GUb6SO25BqDQSLbg7YmjjbloEosfGNhY9vdf8mlPk/7EbEWTW 10gBkKG0jZOlqRrW2fZBbWXHgWh9bghQhB9VgGcWhpxrlxBoQP6rJAlh4MdsgNXS l6RIapN1r43trsU+4oyC24euFa57oRh4OL9uYRQxCLFaw2jTjyHGu/GLy5tBpn3q RQhst6Fx0SvJOzeRwui+Y8q0F4M1hkqzLsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1697805613; x=1697892013; bh=SDZyj5kaO+W34jWN1YiBEhm6U/8Re7fkPDq MiFXCAfI=; b=LCpG7Q/VHHh5eFcRAANkM3P3B/c5kspPgt5/tRQJJyb+2x/+eXc 9v5VUOpA7OVKx9k+dnOf32wpPSgBK9lGAJWBt+O4sfs3h0ufci0lsw4YzqPKRZof 7d8lYIZrAs2agTmKd78wDnyjg6Okuk8elp0iuxMr00V8erbPPeGhiJoOPIi2ZsEt jnrDtxasxS42afRUHGA8oSa8nEgY9ht4x5WetJXwadzFl3jRHXf9toMhSgY1Lyqh V1KX6lOr3wB5GG39+TR6OWRxnwnBxMN/GY6N+V221siZ+Tst1V+CTvl5bJ/+ODTr K7pQmax9tlmx4t0qfAmiQWHs+D74SHznpYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrjeekgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 20 Oct 2023 08:40:12 -0400 (EDT) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <87h6mllijc.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 20 Oct 2023 12:01:11 +0200") References: <2ae9c5496838c6644de4c1199e188e44c7171f0f.1697561146.git.clement@lassieur.org> <87h6mllijc.fsf@gnu.org> Date: Fri, 20 Oct 2023 14:40:10 +0200 Message-ID: <87r0lpsc0l.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.22 X-Spam-Score: -2.22 X-Migadu-Queue-Id: BE7415C704 X-Migadu-Scanner: mx2.migadu.com X-TUID: wMgSXVEXBzJ3 Hey Mathieu, >> + (let* ((id #$(assq-ref properties 'id)) > > id is maybe a bit generic? Done. >> + (firefox (in-vicinity (assoc-ref outputs "firefox"= ) id)) >> + (xpi (assoc-ref outputs "xpi")) >> + (chromium (assoc-ref outputs "chromium"))) >> (install-file "dist/build/uBlock0.firefox.xpi" >> (string-append xpi "/lib/mozilla/extensio= ns")) >> (copy-recursively "dist/build/uBlock0.firefox" firefox) >> @@ -142,3 +146,6 @@ (define ublock-origin >>=20=20 >> (define-public ublock-origin/chromium >> (make-chromium-extension ublock-origin "chromium")) >> + >> +(define-public ublock-origin/icecat >> + (make-icecat-extension ublock-origin "firefox")) > > It does not appear clearly that one has to install ublock-origin-icecat > here. We have the same issue for ublock-origin-chromium though. Indeed! That's a small change that should be in another patch I believe. >> diff --git a/gnu/packages/patches/icecat-compare-paths.patch b/gnu/packa= ges/patches/icecat-compare-paths.patch >> new file mode 100644 >> index 000000000000..9205899dc0c4 >> --- /dev/null >> +++ b/gnu/packages/patches/icecat-compare-paths.patch > > You could add a small header explaining the content of that patch, ... Done. >> --- /dev/null >> +++ b/gnu/packages/patches/icecat-use-system-wide-dir.patch > > ..., as well as that one. Done. > I tried a guix shell icecat ublock-origin-icecat and it worked perfectly > :) It is also very appreciated to have a pre-built icecat by the QA :). Thanks for the review! Cl=C3=A9ment