From: ludo@gnu.org (Ludovic Courtès)
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30404@debbugs.gnu.org
Subject: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Date: Fri, 09 Feb 2018 23:19:17 +0100 [thread overview]
Message-ID: <87po5dx0uy.fsf@gnu.org> (raw)
In-Reply-To: <20180209214356.640edd8f@lepiller.eu> (Julien Lepiller's message of "Fri, 9 Feb 2018 21:44:09 +0100")
Julien Lepiller <julien@lepiller.eu> skribis:
> By the way, if you don't know the author of this package, he's awesome:
> https://www.peppercarrot.com/
Looks very nice indeed!
> From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 12 Jan 2018 23:08:50 +0100
> Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
>
> * gnu/packages/web.scm (cat-avatar-generator): New variable.
LGTM.
> From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 12 Jan 2018 23:14:14 +0100
> Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
>
> * gnu/services/web.scm (cat-avatar-generator-service): New variable.
[...]
> +(define* (cat-avatar-generator-service
> + #:key
> + (cache-dir "/var/cache/cat-avatar-generator")
> + (configuration (nginx-server-configuration)))
> + (simple-service 'cat-http-server nginx-service-type
> + (list (nginx-server-configuration
Normally the 3rd argument would be aligned with the 1st here.
You’ll hate me for asking that, but could you add a couple of lines to
the manual about this service?
Otherwise LGTM!
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-02-09 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 20:44 [bug#30404] [PATCH] Add cat-avatar-generator-service Julien Lepiller
2018-02-09 22:19 ` Ludovic Courtès [this message]
2018-02-09 22:48 ` Julien Lepiller
2018-02-14 19:20 ` Ludovic Courtès
2018-02-14 22:20 ` bug#30404: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po5dx0uy.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30404@debbugs.gnu.org \
--cc=julien@lepiller.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).