From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekH1b-0008I4-6t
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:20:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekH1W-0002Zh-Lv
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:20:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:56189)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ekH1W-0002Zb-If
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:20:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ekH1W-0002MD-8T
	for guix-patches@gnu.org; Fri, 09 Feb 2018 17:20:02 -0500
Subject: [bug#30404] [PATCH] Add cat-avatar-generator-service.
Resent-Message-ID: <handler.30404.B30404.15182147729015@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180209214356.640edd8f@lepiller.eu>
Date: Fri, 09 Feb 2018 23:19:17 +0100
In-Reply-To: <20180209214356.640edd8f@lepiller.eu> (Julien Lepiller's message
	of "Fri, 9 Feb 2018 21:44:09 +0100")
Message-ID: <87po5dx0uy.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 30404@debbugs.gnu.org

Julien Lepiller <julien@lepiller.eu> skribis:

> By the way, if you don't know the author of this package, he's awesome:
> https://www.peppercarrot.com/

Looks very nice indeed!

> From 5375bd9633cb37b3f26d16742fdc451f3296f723 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 12 Jan 2018 23:08:50 +0100
> Subject: [PATCH 1/2] gnu: Add cat-avatar-generator.
>
> * gnu/packages/web.scm (cat-avatar-generator): New variable.

LGTM.

> From b5e362ac44bf3bd284ba14e886960311b67a4019 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 12 Jan 2018 23:14:14 +0100
> Subject: [PATCH 2/2] gnu: Add cat-avatar-generator-service.
>
> * gnu/services/web.scm (cat-avatar-generator-service): New variable.

[...]

> +(define* (cat-avatar-generator-service
> +           #:key
> +           (cache-dir "/var/cache/cat-avatar-generator")
> +           (configuration (nginx-server-configuration)))
> +  (simple-service 'cat-http-server nginx-service-type
> +    (list (nginx-server-configuration

Normally the 3rd argument would be aligned with the 1st here.

You=E2=80=99ll hate me for asking that, but could you add a couple of lines=
 to
the manual about this service?

Otherwise LGTM!

Thanks,
Ludo=E2=80=99.