* [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
@ 2019-05-18 9:02 Reza Alizadeh Majd
2019-05-18 10:22 ` [bug#35789] " Reza Alizadeh Majd
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-18 9:02 UTC (permalink / raw)
To: 35789; +Cc: Reza Alizadeh Majd
* gnu/packages/lxqt.scm (lxqt-session): change lxqt-rc.xml permission to
755 after initial copy to user directory.
---
gnu/packages/lxqt.scm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..94d47bc862 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -827,6 +827,14 @@ allows for launching applications or shutting down the system.")
(("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}")
"DESTINATION \"etc/xdg"))
#t))
+ (add-after 'unpack 'patch-openbox-permission
+ (lambda _
+ (substitute* "startlxqt.in"
+ (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
+ (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
+ " # fix openbox permission issue\n"
+ " chmod -R 755 \"$XDG_CONFIG_HOME/openbox\"")))
+ #t))
(add-after 'unpack 'patch-translations-dir
(lambda* (#:key outputs #:allow-other-keys)
(substitute* '("lxqt-config-session/CMakeLists.txt"
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#35789] lxqt-rc.xml permission issue
2019-05-18 9:02 [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue Reza Alizadeh Majd
@ 2019-05-18 10:22 ` Reza Alizadeh Majd
2019-05-21 14:30 ` [bug#35789] [PATCH] gnu: lxqt-session: fix " Ludovic Courtès
2019-05-21 18:07 ` Reza Alizadeh Majd
2 siblings, 0 replies; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-18 10:22 UTC (permalink / raw)
To: 35789
Hi Guix,
Based on issue that I submitted before
( http://lists.gnu.org/archive/html/help-guix/2019-05/msg00372.html ) ,
lxqt-session copies an openbox related file (lxqt-rc.xml) to user's home directory,
since this file permissions are set as readonly in `gnu/store`, users are unable to
modify this file using openbox settings GUI, for this I submitted following patch to
set proper permessions to `lxqt-rc.xml` file after initial copy to user's home
directory.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
2019-05-18 9:02 [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue Reza Alizadeh Majd
2019-05-18 10:22 ` [bug#35789] " Reza Alizadeh Majd
@ 2019-05-21 14:30 ` Ludovic Courtès
2019-05-21 18:23 ` Reza Alizadeh Majd
2019-05-21 18:07 ` Reza Alizadeh Majd
2 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2019-05-21 14:30 UTC (permalink / raw)
To: Reza Alizadeh Majd; +Cc: 35789
Hello,
Reza Alizadeh Majd <r.majd@pantherx.org> skribis:
> * gnu/packages/lxqt.scm (lxqt-session): change lxqt-rc.xml permission to
> 755 after initial copy to user directory.
[...]
> + (substitute* "startlxqt.in"
> + (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
> + (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
> + " # fix openbox permission issue\n"
> + " chmod -R 755 \"$XDG_CONFIG_HOME/openbox\"")))
That will make every file executable.
What about just:
chmod u+w "$XDG_CONFIG_HOME/openbox"/*
?
One last thing: could you provide the explanation you gave in just one
or two lines of comment right above this ‘substitute*’ expression?
Thank you,
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
2019-05-18 9:02 [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue Reza Alizadeh Majd
2019-05-18 10:22 ` [bug#35789] " Reza Alizadeh Majd
2019-05-21 14:30 ` [bug#35789] [PATCH] gnu: lxqt-session: fix " Ludovic Courtès
@ 2019-05-21 18:07 ` Reza Alizadeh Majd
2019-05-24 15:54 ` bug#35789: " Ludovic Courtès
2 siblings, 1 reply; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-21 18:07 UTC (permalink / raw)
To: 35789; +Cc: Reza Alizadeh Majd
* gnu/packages/lxqt.scm (lxqt-session): add write permission to
lxqt-rc.xml file after initial copy to user directory
---
gnu/packages/lxqt.scm | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/gnu/packages/lxqt.scm b/gnu/packages/lxqt.scm
index d91efe715d..e69f29ed1c 100644
--- a/gnu/packages/lxqt.scm
+++ b/gnu/packages/lxqt.scm
@@ -827,6 +827,15 @@ allows for launching applications or shutting down the system.")
(("DESTINATION \"\\$\\{LXQT_ETC_XDG_DIR\\}")
"DESTINATION \"etc/xdg"))
#t))
+ ;; add write permission to lxqt-rc.xml file which is stored as read-only in store
+ (add-after 'unpack 'patch-openbox-permission
+ (lambda _
+ (substitute* "startlxqt.in"
+ (("cp \"\\$LXQT_DEFAULT_OPENBOX_CONFIG\" \"\\$XDG_CONFIG_HOME/openbox\"")
+ (string-append "cp \"$LXQT_DEFAULT_OPENBOX_CONFIG\" \"$XDG_CONFIG_HOME/openbox\"\n"
+ " # fix openbox permission issue\n"
+ " chmod u+w \"$XDG_CONFIG_HOME/openbox\"/*")))
+ #t))
(add-after 'unpack 'patch-translations-dir
(lambda* (#:key outputs #:allow-other-keys)
(substitute* '("lxqt-config-session/CMakeLists.txt"
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
2019-05-21 14:30 ` [bug#35789] [PATCH] gnu: lxqt-session: fix " Ludovic Courtès
@ 2019-05-21 18:23 ` Reza Alizadeh Majd
0 siblings, 0 replies; 6+ messages in thread
From: Reza Alizadeh Majd @ 2019-05-21 18:23 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 35789
Hi,
> chmod u+w "$XDG_CONFIG_HOME/openbox"/*
you're right, setting the write permission to lxqt-rc.xml is preferred.
I also add a comment line before permission modification phase and amend
my last commit.
Best,
Reza
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#35789: [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue
2019-05-21 18:07 ` Reza Alizadeh Majd
@ 2019-05-24 15:54 ` Ludovic Courtès
0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2019-05-24 15:54 UTC (permalink / raw)
To: Reza Alizadeh Majd; +Cc: 35789-done
Reza Alizadeh Majd <r.majd@pantherx.org> skribis:
> * gnu/packages/lxqt.scm (lxqt-session): add write permission to
> lxqt-rc.xml file after initial copy to user directory
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-24 15:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18 9:02 [bug#35789] [PATCH] gnu: lxqt-session: fix lxqt-rc.xml permission issue Reza Alizadeh Majd
2019-05-18 10:22 ` [bug#35789] " Reza Alizadeh Majd
2019-05-21 14:30 ` [bug#35789] [PATCH] gnu: lxqt-session: fix " Ludovic Courtès
2019-05-21 18:23 ` Reza Alizadeh Majd
2019-05-21 18:07 ` Reza Alizadeh Majd
2019-05-24 15:54 ` bug#35789: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).