unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 51985-done@debbugs.gnu.org, philip@philipmcgrath.com
Subject: bug#51985: lint: Adjust patch file length check.
Date: Sat, 18 Dec 2021 00:26:50 -0800	[thread overview]
Message-ID: <87pmpu8gj9.fsf@ponder> (raw)
In-Reply-To: <87lf18b4dp.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On 2021-11-28, Ludovic Courtès wrote:
> Vagrant Cascadian <vagrant@debian.org> skribis:
>> On 2021-11-25, Ludovic Courtès wrote:
...
>> From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001
>> From: Vagrant Cascadian <vagrant@debian.org>
>> Date: Fri, 26 Nov 2021 12:13:45 -0800
>> Subject: [PATCH] lint: Adjust patch file length check.
>>
>> With the switch to "ustar" format in commit
>> bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has
>> increased.
>>
>> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for
>>   patch file lengths. Increase allowable patch file length appropriate to new
>>   tar format. Extend warning to explain that long files may break 'make dist'.
>> * tests/lint.scm: Update tests accordingly.
>
> [...]
>
>> +                           (G_ "~a: file name is too long which may break 'make dist'")
>
> I think you need a comma before “which”, but other than that LGTM!  :-)

Pushed as 5f547a5c425cc99553ea713703e09a8db9f3c38b with the suggested
comma, and a brief comment explaining what the magic number "151" was
about.

That should bright all the patches into compliance with lint as far as
file length goes, and should work with the ustar format for the "make
dist" produced tarballs.

Don't get too crazy with the extra ~50 characters!

live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

      reply	other threads:[~2021-12-18  8:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19 21:05 [bug#51985] lint: Adjust patch file length check Vagrant Cascadian
2021-11-22 11:22 ` Ludovic Courtès
2021-11-24 21:25   ` Vagrant Cascadian
2021-11-25 13:08     ` Ludovic Courtès
2021-11-26 21:08       ` Vagrant Cascadian
2021-11-28 17:02         ` Ludovic Courtès
2021-12-18  8:26           ` Vagrant Cascadian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmpu8gj9.fsf@ponder \
    --to=vagrant@debian.org \
    --cc=51985-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=philip@philipmcgrath.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).