From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iLmFAaSbvWHmqgAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 09:28:20 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wFrjOKObvWFmKQAA1q6Kng (envelope-from ) for ; Sat, 18 Dec 2021 08:28:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A60771E7F for ; Sat, 18 Dec 2021 09:28:19 +0100 (CET) Received: from localhost ([::1]:41950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myV4k-0004JE-JA for larch@yhetil.org; Sat, 18 Dec 2021 03:28:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38404) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myV4U-0004Ic-D3 for guix-patches@gnu.org; Sat, 18 Dec 2021 03:28:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57926) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myV4U-0005RI-4v for guix-patches@gnu.org; Sat, 18 Dec 2021 03:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myV4U-0001ao-2M for guix-patches@gnu.org; Sat, 18 Dec 2021 03:28:02 -0500 Subject: bug#51985: lint: Adjust patch file length check. Resent-From: Vagrant Cascadian Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 08:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 51985 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51985-done@debbugs.gnu.org, philip@philipmcgrath.com Mail-Followup-To: 51985@debbugs.gnu.org, vagrant@debian.org, vagrant@debian.org Received: via spool by 51985-done@debbugs.gnu.org id=D51985.16398160276056 (code D ref 51985); Sat, 18 Dec 2021 08:28:01 +0000 Received: (at 51985-done) by debbugs.gnu.org; 18 Dec 2021 08:27:07 +0000 Received: from localhost ([127.0.0.1]:41239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myV3b-0001Zc-Gp for submit@debbugs.gnu.org; Sat, 18 Dec 2021 03:27:07 -0500 Received: from cascadia.aikidev.net ([173.255.214.101]:39062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myV3Z-0001Z6-Iz for 51985-done@debbugs.gnu.org; Sat, 18 Dec 2021 03:27:05 -0500 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:21:21:0:100e]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 6EA9E1AA2C; Sat, 18 Dec 2021 00:26:59 -0800 (PST) From: Vagrant Cascadian In-Reply-To: <87lf18b4dp.fsf@gnu.org> References: <875ysnsvnt.fsf@yucca> <877dd0ph9g.fsf@gnu.org> <8735nl5jri.fsf@ponder> <8735nke61x.fsf@gnu.org> <87ee72fwv0.fsf@ponder> <87lf18b4dp.fsf@gnu.org> Date: Sat, 18 Dec 2021 00:26:50 -0800 Message-ID: <87pmpu8gj9.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639816099; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=rmP4W2l7p3Zul2JJeZDaFIXaIL10wTV/caF1cXxWuTg=; b=cBctq7pLHQmzqmbofZuRZkzFFTKqgv2A1ki/LKgJ/4Ke+YppKCZTK1VbLtN7WLTnyC1TyB 3Uv6oM7MW2T/G/ggwM8feyrw1RrNANF65reuCO8cfqJcmoijxYDZNtq5risvejAzai8mFN 6wVuuFpkbFzT6UoGl1s9mQDhZ/uRB0hnogKIKdLlkIBtjClpU4PhYFd9CGvKoIgv93E6Fw L0IIB2mGdzBJV+2xZaCzoYr92xdGtCnOfwxiVyfv0V/RCZyCmgUIiUxf4TarUsv9l18/su zrPKxy0w6dgB4lT/2HI31o9/8HLVa+EaLmun3TqN9W4hwqXxXP29oW0QXPRfTw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639816099; a=rsa-sha256; cv=none; b=tsznfZwaJWYERYCGXNGI+RSDYqrZB6BWU67KqE39VjZ3adgrCLbdajDJlG1nYQpRMaFiFT 3o4/7y5XCtuE1aFr0nQAbXYzAmX1eE73cwF02Wc7QjJ3zdoiaMQ9hmDJRIxvRHg2Dd8sWt 8M9snCiTQVP/p7ICZFQWjR7TEg1wRpNzNRGF5kSDGcGXIPKk7an8HYEyicvO6KHqoQd4LN CHOIv1f9652HbXOmS6SCVeP3Saip2oosZYT4hVO55nmxvw51tHrzSV7XVRHl67Xb+zM/gM Pi7rzdV/srcwAPY0XdNxBWqsuZwvELFjaErA4imfXhQtmm3F7YGnE3pHDSRGrQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.40 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A60771E7F X-Spam-Score: -5.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: OKYC+f8z8OeA --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2021-11-28, Ludovic Court=C3=A8s wrote: > Vagrant Cascadian skribis: >> On 2021-11-25, Ludovic Court=C3=A8s wrote: ... >> From c0738574a3571977855d655c157ab0ea0f9be6ef Mon Sep 17 00:00:00 2001 >> From: Vagrant Cascadian >> Date: Fri, 26 Nov 2021 12:13:45 -0800 >> Subject: [PATCH] lint: Adjust patch file length check. >> >> With the switch to "ustar" format in commit >> bdf5c16ac052af2ca9d5c3acc4acbc08fd9fdbea, the maximum file length has >> increased. >> >> * guix/lint.scm (check-patch-file-names): Adjust margin used to check for >> patch file lengths. Increase allowable patch file length appropriate t= o new >> tar format. Extend warning to explain that long files may break 'make = dist'. >> * tests/lint.scm: Update tests accordingly. > > [...] > >> + (G_ "~a: file name is too long which may bre= ak 'make dist'") > > I think you need a comma before =E2=80=9Cwhich=E2=80=9D, but other than t= hat LGTM! :-) Pushed as 5f547a5c425cc99553ea713703e09a8db9f3c38b with the suggested comma, and a brief comment explaining what the magic number "151" was about. That should bright all the patches into compliance with lint as far as file length goes, and should work with the ustar format for the "make dist" produced tarballs. Don't get too crazy with the extra ~50 characters! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYb2bTgAKCRDcUY/If5cW qsnMAQDtqRlxdhb0TlUbiNPakFExNOK2GUTkQ8I5+7KW3Js4kAD/QKRsfe1tEqqO lidYhHvSCxGFGgcTpRv8VZcW/laotQ0= =s4KP -----END PGP SIGNATURE----- --=-=-=--