* [bug#56884] [PATCH] Make x265 build on ppc64le
@ 2022-08-02 12:10 Marcel van der Boom
2022-08-09 8:02 ` Marcel van der Boom
2022-08-10 7:19 ` Marcel van der Boom
0 siblings, 2 replies; 7+ messages in thread
From: Marcel van der Boom @ 2022-08-02 12:10 UTC (permalink / raw)
To: 56884; +Cc: Marcel van der Boom
* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
---
gnu/packages/video.scm | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..09f8b7fd23 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,9 @@ (define-public x265
,@(if (target-aarch64?)
'("-DENABLE_ASSEMBLY=OFF")
'())
+ ,@(if (target-ppc64le?)
+ '("-DENABLE_ALTIVEC=OFF")
+ '())
"-DHIGH_BIT_DEPTH=ON"
"-DEXPORT_C_API=OFF"
"-DENABLE_CLI=OFF"
@@ -1272,6 +1275,9 @@ (define-public x265
,@(if (target-aarch64?)
'("-DENABLE_ASSEMBLY=OFF")
'())
+ ,@(if (target-ppc64le?)
+ '("-DENABLE_ALTIVEC=OFF")
+ '())
"-DHIGH_BIT_DEPTH=ON"
"-DEXPORT_C_API=OFF"
"-DENABLE_CLI=OFF"
base-commit: a1f7d98a9c7380be5815fd13b519bbab145757c2
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#56884] [PATCH] Make x265 build on ppc64le
2022-08-02 12:10 [bug#56884] [PATCH] Make x265 build on ppc64le Marcel van der Boom
@ 2022-08-09 8:02 ` Marcel van der Boom
2022-08-10 2:16 ` Thiago Jung Bauermann via Guix-patches via
2022-08-10 7:19 ` Marcel van der Boom
1 sibling, 1 reply; 7+ messages in thread
From: Marcel van der Boom @ 2022-08-09 8:02 UTC (permalink / raw)
To: 56884
Anything else needed here?
The patch seems consistent with other packagers I think. Others
are also confused on what is needed for the altivec code between
different POWER processors.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#56884] [PATCH] Make x265 build on ppc64le
2022-08-09 8:02 ` Marcel van der Boom
@ 2022-08-10 2:16 ` Thiago Jung Bauermann via Guix-patches via
0 siblings, 0 replies; 7+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2022-08-10 2:16 UTC (permalink / raw)
To: Marcel van der Boom; +Cc: 56884
Hello Marcel,
Marcel van der Boom <marcel@van-der-boom.nl> writes:
> Anything else needed here?
>
> The patch seems consistent with other packagers I think.
Thank you for the patch! It looks good to me. I only have one
suggestion: IMHO it would be a good idea to have a short comment above
the “(if (target-ppc64le?) …)” line explaining why it's needed, such as
“Enabling AltiVec support causes compilation errors.” or something
similar.
Ideally upstream should be notified about this problem so that they are
aware of it, but looking at the x265 website I can't find any bug
tracker.
> Others are also confused on what is needed for the altivec code
> between different POWER processors.
Sorry, I'm not sure what you mean.
PS: Just for the sake of documenting in the issue tracker why x265 isn't
building on ppc64le — the build fails because of many errors such as:
/tmp/guix-build-x265-3.5.drv-0/x265_3.5/source/common/ppc/pixel_altivec.cpp:4199:42: error: no matches converting function ‘sad16_altivec’ to type ‘x265_12bit::pixelcmp_t’ {aka ‘int (*)(const short unsigned int*, long int, const short unsigned int*, long int)’}
4199 | p.pu[LUMA_ ## W ## x ## H].sad = sad16_altivec<W, H>; \
| ^~~~~~~~~~~~~~~~~~~
--
Thanks
Thiago
^ permalink raw reply [flat|nested] 7+ messages in thread
* [bug#56884] [PATCH] Make x265 build on ppc64le
2022-08-02 12:10 [bug#56884] [PATCH] Make x265 build on ppc64le Marcel van der Boom
2022-08-09 8:02 ` Marcel van der Boom
@ 2022-08-10 7:19 ` Marcel van der Boom
2022-08-11 2:15 ` Thiago Jung Bauermann via Guix-patches via
1 sibling, 1 reply; 7+ messages in thread
From: Marcel van der Boom @ 2022-08-10 7:19 UTC (permalink / raw)
To: 56884; +Cc: Marcel van der Boom, Thiago Jung Bauermann
* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
Build produces many errors. The altivec code needs adjusting each type of
POWER processor specifically.
---
gnu/packages/video.scm | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..bf033c7d84 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,10 @@ (define-public x265
,@(if (target-aarch64?)
'("-DENABLE_ASSEMBLY=OFF")
'())
+ ;; Altivec code produces many build errors
+ ,@(if (target-ppc64le?)
+ '("-DENABLE_ALTIVEC=OFF")
+ '())
"-DHIGH_BIT_DEPTH=ON"
"-DEXPORT_C_API=OFF"
"-DENABLE_CLI=OFF"
@@ -1272,6 +1276,10 @@ (define-public x265
,@(if (target-aarch64?)
'("-DENABLE_ASSEMBLY=OFF")
'())
+ ;; Altivec code produces many build errors
+ ,@(if (target-ppc64le?)
+ '("-DENABLE_ALTIVEC=OFF")
+ '())
"-DHIGH_BIT_DEPTH=ON"
"-DEXPORT_C_API=OFF"
"-DENABLE_CLI=OFF"
--
2.37.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [bug#56884] [PATCH] Make x265 build on ppc64le
2022-08-10 7:19 ` Marcel van der Boom
@ 2022-08-11 2:15 ` Thiago Jung Bauermann via Guix-patches via
2022-08-11 7:45 ` bug#56884: " Mathieu Othacehe
0 siblings, 1 reply; 7+ messages in thread
From: Thiago Jung Bauermann via Guix-patches via @ 2022-08-11 2:15 UTC (permalink / raw)
To: Marcel van der Boom; +Cc: 56884
user guix
usertag 56884 reviewed looks-good
quit
Hello Marcel,
Marcel van der Boom <marcel@van-der-boom.nl> writes:
> * gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
>
> Build produces many errors. The altivec code needs adjusting each type of
> POWER processor specifically.
Thank you for the new version. This one looks good to me.
I'm not a maintainer though, so we need to wait for one to chime in.
--
Thanks
Thiago
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-08-11 14:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 12:10 [bug#56884] [PATCH] Make x265 build on ppc64le Marcel van der Boom
2022-08-09 8:02 ` Marcel van der Boom
2022-08-10 2:16 ` Thiago Jung Bauermann via Guix-patches via
2022-08-10 7:19 ` Marcel van der Boom
2022-08-11 2:15 ` Thiago Jung Bauermann via Guix-patches via
2022-08-11 7:45 ` bug#56884: " Mathieu Othacehe
2022-08-11 14:50 ` [bug#56884] " Thiago Jung Bauermann via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).