unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building static libraries.
@ 2022-11-16 22:52 Kaelyn Takata via Guix-patches via
  2022-11-17 18:24 ` Marius Bakke
  0 siblings, 1 reply; 2+ messages in thread
From: Kaelyn Takata via Guix-patches via @ 2022-11-16 22:52 UTC (permalink / raw)
  To: 59324; +Cc: Kaelyn Takata

* gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
fix linking issues for packages such as mpv.
---
 gnu/packages/vulkan.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index c00c06d7f3..6840f66c68 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -91,6 +91,9 @@ (define-public spirv-tools
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
+                               ;; Some packages like mpv fail to link
+                               ;; when the static libraries are built.
+                               "-DSPIRV_TOOLS_BUILD_STATIC=OFF"
                                (string-append
                                 "-DSPIRV-Headers_SOURCE_DIR="
                                 (assoc-ref %build-inputs "spirv-headers")))))

base-commit: 29754d3683acd188c2c461b934227ba1d909ac63
--
2.38.0






^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building static libraries.
  2022-11-16 22:52 [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building static libraries Kaelyn Takata via Guix-patches via
@ 2022-11-17 18:24 ` Marius Bakke
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Bakke @ 2022-11-17 18:24 UTC (permalink / raw)
  To: 59324, 59324-done; +Cc: Kaelyn Takata

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

Kaelyn Takata via Guix-patches via <guix-patches@gnu.org> skriver:

> * gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
> fix linking issues for packages such as mpv.

Pushed to 'staging' as 522d21863e, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-17 18:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 22:52 [bug#59324] [PATCH staging] gnu: spirv-tools: Disable building static libraries Kaelyn Takata via Guix-patches via
2022-11-17 18:24 ` Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).