unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: phodina <phodina@protonmail.com>
Cc: 59851@debbugs.gnu.org
Subject: [bug#59851] Add Moonlight
Date: Mon, 16 Jan 2023 10:59:59 -0500	[thread overview]
Message-ID: <87pmbe8o74.fsf@gmail.com> (raw)
In-Reply-To: <m_E7NdSsSdVPdQnIJ0A8fmwr7jmZ7RBn2qrDdCMW_P1FkzdxTLayYwf5gSYStidtqPw4MJolQi3BUc6qaUmX2xlpHSvJaQYb8t8oNs1d8es=@protonmail.com> (phodina@protonmail.com's message of "Tue, 06 Dec 2022 03:17:28 +0000")

Hi,

phodina <phodina@protonmail.com> writes:

> Hello,
>
> these patches add support for game streaming solution for Nvidia GameStream protocol. The client is open source. However, the games and the server is a non-libre application.
>
> ----
> Petr
>
>
>
>
> From 2034d229893bd6b96e66c588f235da36efc025b9 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Sat, 3 Dec 2022 10:34:03 +0100
> Subject: [PATCH 3/6] gnu: Add h264bitstream.
>
> * gnu/packages/video.scm (h264bitstream): New variable.

[...]

> +      (build-system gnu-build-system)
> +      (arguments
> +       (list #:tests? #f ;no test suite
> +             #:phases #~(modify-phases %standard-phases
> +                          (add-after 'install 'fix-include-bs-h
> +                            (lambda* _

Replace lambda* with lambda.

> +                              (display "")

Remove this extraneous display call.

> +                              (symlink (string-append #$output
> +                                        "/include/h264bitstream/bs.h")
> +                                       (string-append #$output "/include/bs.h")))))))
> +      (native-inputs (list autoconf automake libtool pkg-config))
> +      (inputs (list ffmpeg))
> +      (synopsis "Library to read and write H.264 video bitstreams")
> +      (description
> +       "This package provides the code GameStream code shared between @code{Moonlight} clients.")

There's a typo above, with 'code' repeated twice.  Since Moonlight is a
proper noun, I'd leave out the @code decorator for it.

Otherwise, LGTM.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-01-16 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  3:17 [bug#59851] Add Moonlight phodina via Guix-patches via
2023-01-16 15:03 ` Maxim Cournoyer
2023-01-16 15:04 ` Maxim Cournoyer
2023-01-16 15:59 ` Maxim Cournoyer [this message]
2023-01-16 16:05 ` Maxim Cournoyer
2023-01-16 16:11 ` Maxim Cournoyer
2023-01-16 16:12 ` Maxim Cournoyer
2023-01-17  8:07   ` phodina via Guix-patches via
2023-01-17 16:29     ` Maxim Cournoyer
2023-01-17 16:35     ` Maxim Cournoyer
2023-03-21 14:07       ` Maxim Cournoyer
2024-01-21 13:22         ` bug#59851: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmbe8o74.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=59851@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).