unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: phodina <phodina@protonmail.com>
Cc: 59851@debbugs.gnu.org
Subject: [bug#59851] Add Moonlight
Date: Tue, 17 Jan 2023 11:29:21 -0500	[thread overview]
Message-ID: <87cz7d15we.fsf@gmail.com> (raw)
In-Reply-To: <RgzlT6EkYv29_6-nDwzgii-eatP9OURzDVFm124uxVtqFhcPqHKXjnvqaHCLA_WOi520VarFzwZrI35mAk5oAi10IW3-w4PdjABUwOXbCpg=@protonmail.com> (phodina@protonmail.com's message of "Tue, 17 Jan 2023 08:07:14 +0000")

Hi Petr,

phodina <phodina@protonmail.com> writes:

> From a923f2a2e49a0a9851e43aec325fbaee1ee8b4cb Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina@protonmail.com>
> Date: Mon, 5 Dec 2022 16:19:08 +0100
> Subject: [PATCH v2 5/6] gnu: Add sdl-gamecontrollerdb.
>
> * gnu/packages/sdl.scm (sdl-gamecontrollerdb): New variable.

Apologies, it looks like I forgot to review that one in the original
submission.

> diff --git a/gnu/packages/sdl.scm b/gnu/packages/sdl.scm
> index 0c419dfaca..90c04c98d9 100644
> --- a/gnu/packages/sdl.scm
> +++ b/gnu/packages/sdl.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2020 Timotej Lazar <timotej.lazar@araneo.si>
>  ;;; Copyright © 2020 Oleg Pykhalov <go.wigust@gmail.com>
>  ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer@gmail.com>
> +;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -41,6 +42,7 @@ (define-module (gnu packages sdl)
>    #:use-module (guix download)
>    #:use-module (guix git-download)
>    #:use-module (guix utils)
> +  #:use-module (guix build-system copy)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system trivial)
>    #:use-module (gnu packages audio)
> @@ -199,6 +201,29 @@ (define-public libmikmod
>      (license license:lgpl2.1)
>      (home-page "http://mikmod.sourceforge.net/")))
>  
> +(define-public sdl-gamecontrollerdb
> +  (let ((commit "9bd061ec6282cd9f8ee0eff36112d98096183a82")
> +        (revision "1"))
> +    (package
> +      (name "sdl-gamecontrollerdb")
> +      (version "")
                  ^
Oops! :-)

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/gabomdq/SDL_GameControllerDB")
> +                      (commit commit)))
> +                (sha256
> +                 (base32
> +                  "1dzch3c39n1kq8m5h8fpi7aqqv6k5jqwmlyagsh6fmyzwjviqgji"))))
> +      (build-system copy-build-system)
> +      (arguments
> +       '(#:install-plan '(("gamecontrollerdb.txt" "gamecontrollerdb.txt"))))
> +      (synopsis "Database of game controller mappings to be used with SDL2
> +	Game Controller")
> +      (description "")

                      ^
The synopsis and description need to be reworked here.

Otherwise, LGTM.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-01-17 16:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  3:17 [bug#59851] Add Moonlight phodina via Guix-patches via
2023-01-16 15:03 ` Maxim Cournoyer
2023-01-16 15:04 ` Maxim Cournoyer
2023-01-16 15:59 ` Maxim Cournoyer
2023-01-16 16:05 ` Maxim Cournoyer
2023-01-16 16:11 ` Maxim Cournoyer
2023-01-16 16:12 ` Maxim Cournoyer
2023-01-17  8:07   ` phodina via Guix-patches via
2023-01-17 16:29     ` Maxim Cournoyer [this message]
2023-01-17 16:35     ` Maxim Cournoyer
2023-03-21 14:07       ` Maxim Cournoyer
2024-01-21 13:22         ` bug#59851: " Oleg Pykhalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz7d15we.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=59851@debbugs.gnu.org \
    --cc=phodina@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).