[bug#70380] [PATCH v3 1/4] maint: Cater for running `make dist' from tarball.

[Janneke Nieuwenhuizen <janneke@gnu.org>]

pelzflorian (Florian Pelz) writes:

Hello Florian,

> Hello Jan.  Thank you for fixing “make dist” from a tarball, which
> admittedly is far-fetched.  However, “make” from a tarball is not
> actually fixed / catered for and is essential.

Ouch, how did I miss that?

> [100%] GUILEC   guix/scripts/discover.go
> [100%] GUILEC   guix/scripts/offload.go
>   HELP2MAN doc/guix-daemon.1
> make[2]: *** No rule to make target 'etc/git/pre-push', needed by '.git/hooks/pre-push'.  Stop.
> make[2]: Leaving directory '/home/florian/guix-1.3.0.58013-5dfeb'
> make[1]: *** [Makefile:6304: all-recursive] Error 1
> make[1]: Leaving directory '/home/florian/guix-1.3.0.58013-5dfeb'
> make: *** [Makefile:4371: all] Error 2
>
> I suppose it is not actually your fault, but since you know how to fix
> it, would you fix it?

Ah, indeed.  It was broken almost a year ago.  Your suggestion makes
much sense to me, so I'm including a new patch in V4 to address this.

It required moving in_git_p from GNU make to to configure.ac and
introducing it earlier.

> Note that the non-fatal “./bootstrap” errors from tarball (sh: line 1:
> build-aux/git-version-gen: No such file or directory ) are not fixed
> either, but they are not fatal.

Yes, I don't know what to do about it.  Looks like an Autotools bug to
me.

> Janneke Nieuwenhuizen <janneke@gnu.org> writes:
>> +dist: doc-pot-update
>> +$(warning Not using Git, tarball will likely be irreproducible!)
>
> I get this warning when running “make” from a tarball, not only “make
> dist”.

Oops, fixed in V4.

> However (!) “make dist” from the same (rebuilt reproducibly from
> the git repo with your patches) tarball on another machine is in my case
> perfectly reproducible, so could you just drop the warning?

Hmm.  You're probably rightt.  I tried touching files, run update-po,
but reproducibility seems pretty resilient to such changes.  I've chosen
to keep it anyway just to discourage maintainers from doing such a
thing.

> Thank you for making Guix more secure.

Most happy to.  Thanks for your reviews!

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com