From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id WFBlBi0dIGYrYgEAqHPOHw:P1 (envelope-from ) for ; Wed, 17 Apr 2024 21:04:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id WFBlBi0dIGYrYgEAqHPOHw (envelope-from ) for ; Wed, 17 Apr 2024 21:04:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NYQ8SaFx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713380653; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6OruMmRRGS+/TtE/ZxPpkmbt2AoLRjjj1NaU2Y6MAns=; b=TA626wSf4VWFXPfZX5fOb5Vf1m3aO4C8An0kC7aJT/LF8+k18GzayG//F+MKiZxvQgxKw9 ATr14k40gVIomgqN7hdj8iixnyqi8Tv6cktNV1qHASa2npfHHS/EbFUJZSyF3+N5v0SZXu x0CJeppDZlAWNWU3CIVXQStCIQihp6uB2/qyonIRSsmcp4xJS7Dz57Ga3HXFV2sj1ZTPxZ rX73+ipwh6jfwZgY/JNk4p1xqOfOjARf2i4AIn1RVByb1bRmBVaZC+Z3LzX75vlJZvFZIE K0fqgASqkP/qQqdZAVzom8fOQmp9fiy0wOWVcxXC3WGqhSmEYJfWFSJgo0uHsQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713380653; a=rsa-sha256; cv=none; b=kcKX+ACqnt5mOhTH5mKXiktCh3cIzZ5W1ZvGRWMd+iFU0S1an00XNVcAAF2AN9d+cnFO7C MP6JXa+E56oQKXgfNyQ+lNbn91Nrfu9UNQDPXcdMOupnCAucMkFm/7XZHdNaMzCaScAScL RD/G2sDUtbVEwRrp7VJ1y+ufzcAI3ofcPIQwsLtS7342Jd0NeJtUi6Gfsa9vcU0or+iAqA MybS7AwF6IYzQ7Yc1ntp6WJKKux2S/ew5eLVIr/qhqiBkal+DhJhvOX37NED+khv92oI12 Qp2waA2qDRa16IMSCuY/HCYV1F+U7qJfUMe6ukBm8mOTwLnWkRcY9tp2JxHG5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=NYQ8SaFx; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5CC58642F9 for ; Wed, 17 Apr 2024 21:04:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxAZT-0002G3-Oa; Wed, 17 Apr 2024 15:03:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxAZR-0002Fr-Bc for guix-patches@gnu.org; Wed, 17 Apr 2024 15:03:49 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxAZR-00027X-3U for guix-patches@gnu.org; Wed, 17 Apr 2024 15:03:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxAZe-0008J4-2s for guix-patches@gnu.org; Wed, 17 Apr 2024 15:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70380] [PATCH v3 1/4] maint: Cater for running `make dist' from tarball. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 17 Apr 2024 19:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70380 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: 70380@debbugs.gnu.org Received: via spool by 70380-submit@debbugs.gnu.org id=B70380.171338062931824 (code B ref 70380); Wed, 17 Apr 2024 19:04:02 +0000 Received: (at 70380) by debbugs.gnu.org; 17 Apr 2024 19:03:49 +0000 Received: from localhost ([127.0.0.1]:47565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxAZO-0008Gy-GX for submit@debbugs.gnu.org; Wed, 17 Apr 2024 15:03:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxAZK-0008F5-AR for 70380@debbugs.gnu.org; Wed, 17 Apr 2024 15:03:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxAZ0-00024k-BS; Wed, 17 Apr 2024 15:03:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=6OruMmRRGS+/TtE/ZxPpkmbt2AoLRjjj1NaU2Y6MAns=; b=NYQ8SaFx5E9jdaJaE98T W2Ou1v+ttbQi7jH9jfgsGuXEzC8Zw0sN2BGU49CjFU8f2RR2YaCaKYkzDpKjhdYp/6ds3eRszR6mp vla3q5LJYMG1TvkFmqFA1qBeBSoblKM4J485t0e2ulZn4aAfTTzazI0PmaxVKUITMeXWCMdLieBsi 6w7wD11BCe2sJ5UZgpd9Tz5A/tS2vRwHyukdsbehFihQDKUO5T0e75PyRtFYORJQOOLO2jI6sYqr8 SsaEH09E8engn/x4ePwbPMQwsG41z+J2zUMjqIdCduWW/ZhgOJojo7rlOO6pK3XXOFad/d9SewcxM qDpTKGTqlbptXA==; From: Janneke Nieuwenhuizen In-Reply-To: <87jzkwov9t.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Wed, 17 Apr 2024 17:37:18 +0200") Organization: AvatarAcademy.nl References: <9dd6e4436bcc0639cbbae2d468e5bc3760d73aa3.1713340673.git.janneke@gnu.org> <87jzkwov9t.fsf@pelzflorian.de> X-Url: http://AvatarAcademy.nl Date: Wed, 17 Apr 2024 21:02:54 +0200 Message-ID: <87plunyfq9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.08 X-Spam-Score: -7.08 X-Migadu-Queue-Id: 5CC58642F9 X-Migadu-Scanner: mx13.migadu.com X-TUID: yjev5zoYfY0O pelzflorian (Florian Pelz) writes: Hello Florian, > Hello Jan. Thank you for fixing =E2=80=9Cmake dist=E2=80=9D from a tarba= ll, which > admittedly is far-fetched. However, =E2=80=9Cmake=E2=80=9D from a tarbal= l is not > actually fixed=C2=A0/ catered for and is essential. Ouch, how did I miss that? > [100%] GUILEC guix/scripts/discover.go > [100%] GUILEC guix/scripts/offload.go > HELP2MAN doc/guix-daemon.1 > make[2]: *** No rule to make target 'etc/git/pre-push', needed by '.git/h= ooks/pre-push'. Stop. > make[2]: Leaving directory '/home/florian/guix-1.3.0.58013-5dfeb' > make[1]: *** [Makefile:6304: all-recursive] Error 1 > make[1]: Leaving directory '/home/florian/guix-1.3.0.58013-5dfeb' > make: *** [Makefile:4371: all] Error 2 > > I suppose it is not actually your fault, but since you know how to fix > it, would you fix it? Ah, indeed. It was broken almost a year ago. Your suggestion makes much sense to me, so I'm including a new patch in V4 to address this. It required moving in_git_p from GNU make to to configure.ac and introducing it earlier. > Note that the non-fatal =E2=80=9C./bootstrap=E2=80=9D errors from tarball= (sh: line 1: > build-aux/git-version-gen: No such file or directory ) are not fixed > either, but they are not fatal. Yes, I don't know what to do about it. Looks like an Autotools bug to me. > Janneke Nieuwenhuizen writes: >> +dist: doc-pot-update >> +$(warning Not using Git, tarball will likely be irreproducible!) > > I get this warning when running =E2=80=9Cmake=E2=80=9D from a tarball, no= t only =E2=80=9Cmake > dist=E2=80=9D. Oops, fixed in V4. > However (!) =E2=80=9Cmake dist=E2=80=9D from the same (rebuilt reproducib= ly from > the git repo with your patches) tarball on another machine is in my case > perfectly reproducible, so could you just drop the warning? Hmm. You're probably rightt. I tried touching files, run update-po, but reproducibility seems pretty resilient to such changes. I've chosen to keep it anyway just to discourage maintainers from doing such a thing. > Thank you for making Guix more secure. Most happy to. Thanks for your reviews! Greetings, Janneke --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com