* [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
@ 2017-12-16 19:20 Christopher Baines
2017-12-16 20:25 ` Leo Famulari
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Christopher Baines @ 2017-12-16 19:20 UTC (permalink / raw)
To: 29740
This improves the performance of the shared store for operations involving
lots of files, e.g. searching through the store.
* gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
---
gnu/system/vm.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index 6102d465b..c1305d3f9 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -554,7 +554,7 @@ of the GNU system as described by OS."
(device (file-system->mount-tag source))
(type "9p")
(flags (if writable? '() '(read-only)))
- (options (string-append "trans=virtio"))
+ (options "trans=virtio,cache=loose")
(check? #f)
(create-mount-point? #t)))))
--
2.15.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
2017-12-16 19:20 [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system Christopher Baines
@ 2017-12-16 20:25 ` Leo Famulari
2017-12-16 21:10 ` Christopher Baines
2017-12-17 16:11 ` Ludovic Courtès
2017-12-17 20:54 ` bug#29740: done Christopher Baines
2 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-12-16 20:25 UTC (permalink / raw)
To: Christopher Baines; +Cc: 29740
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
> This improves the performance of the shared store for operations involving
> lots of files, e.g. searching through the store.
>
> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
Okay!
> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
> index 6102d465b..c1305d3f9 100644
> --- a/gnu/system/vm.scm
> +++ b/gnu/system/vm.scm
> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
> (device (file-system->mount-tag source))
> (type "9p")
> (flags (if writable? '() '(read-only)))
> - (options (string-append "trans=virtio"))
> + (options "trans=virtio,cache=loose")
Was that string-append unnecessary in this context?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
2017-12-16 20:25 ` Leo Famulari
@ 2017-12-16 21:10 ` Christopher Baines
0 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2017-12-16 21:10 UTC (permalink / raw)
To: Leo Famulari; +Cc: 29740
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
Leo Famulari <leo@famulari.name> writes:
> On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>>
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> Okay!
>
>> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
>> index 6102d465b..c1305d3f9 100644
>> --- a/gnu/system/vm.scm
>> +++ b/gnu/system/vm.scm
>> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
>> (device (file-system->mount-tag source))
>> (type "9p")
>> (flags (if writable? '() '(read-only)))
>> - (options (string-append "trans=virtio"))
>> + (options "trans=virtio,cache=loose")
>
> Was that string-append unnecessary in this context?
I think so. It has always been like this I think, and I haven't had any
problems with this change.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
2017-12-16 19:20 [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system Christopher Baines
2017-12-16 20:25 ` Leo Famulari
@ 2017-12-17 16:11 ` Ludovic Courtès
2017-12-17 20:53 ` Christopher Baines
2017-12-17 20:54 ` bug#29740: done Christopher Baines
2 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2017-12-17 16:11 UTC (permalink / raw)
To: Christopher Baines; +Cc: 29740
Christopher Baines <mail@cbaines.net> skribis:
> This improves the performance of the shared store for operations involving
> lots of files, e.g. searching through the store.
>
> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
That’s a good idea, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
2017-12-17 16:11 ` Ludovic Courtès
@ 2017-12-17 20:53 ` Christopher Baines
0 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2017-12-17 20:53 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 29740
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Christopher Baines <mail@cbaines.net> skribis:
>
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>>
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> That’s a good idea, thank you!
I've now pushed this patch. Thanks for reviewing :)
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#29740: done
2017-12-16 19:20 [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system Christopher Baines
2017-12-16 20:25 ` Leo Famulari
2017-12-17 16:11 ` Ludovic Courtès
@ 2017-12-17 20:54 ` Christopher Baines
2 siblings, 0 replies; 6+ messages in thread
From: Christopher Baines @ 2017-12-17 20:54 UTC (permalink / raw)
To: 29740-done
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-17 20:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-16 19:20 [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system Christopher Baines
2017-12-16 20:25 ` Leo Famulari
2017-12-16 21:10 ` Christopher Baines
2017-12-17 16:11 ` Ludovic Courtès
2017-12-17 20:53 ` Christopher Baines
2017-12-17 20:54 ` bug#29740: done Christopher Baines
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).