From: Oleg Pykhalov <go.wigust@gmail.com>
To: Pierre Langlois <pierre.langlois@gmx.com>
Cc: 33311@debbugs.gnu.org
Subject: [bug#33311] [PATCH] gnu: Drop non-sbcl lisp support from Stumpwm 2018.05.
Date: Wed, 28 Nov 2018 19:25:22 +0300 [thread overview]
Message-ID: <87o9a96ufh.fsf@gmail.com> (raw)
In-Reply-To: <cubsh0b6g6g.fsf@gmx.com> (Pierre Langlois's message of "Thu, 08 Nov 2018 10:01:59 +0000")
[-- Attachment #1: Type: text/plain, Size: 2707 bytes --]
Hello Pierre,
Apologies for not getting attention to this patch for a long time. Also
thank you for working on StumpWM package! I've succeeded to build and
run it. Please, take a look onto my notes about your patch below.
Pierre Langlois <pierre.langlois@gmx.com> writes:
> I'm in the process of switching back to StumpWM as my main window
> manager, and when taking a look at the package, I realised we still
> supported non-sbcl builds while upstream dropped them after version
> 1.0.0 [0]. So since StumpWM now only supports sbcl, I thought we should
> just rename it to "stumpwm" instead of "sbcl-stumpwm", as that's
> redundant. And then we can keep the ecl-stumpwm variant, but downgraded
> to 1.0.0
[…]
> [0]: http://lists.nongnu.org/archive/html/stumpwm-devel/2017-01/msg00007.html
Is there a reason to preserve an unmaintained ECL variant of StumpWM? My
guess is StumpWM users will stick to SBCL upstream version. Also
according to ‘M-x build-farm b =j ecl-stumpwm-18.05.x86_64-linux’
package is failed to build for a long time. WDYT?
Please, add the following for Guix users with sbcl-stumpwm installed:
--8<---------------cut here---------------start------------->8---
(define-public sbcl-stumpwm
(deprecated-package "sbcl-stumpwm" stumpwm))
--8<---------------cut here---------------end--------------->8---
[…]
>>From 8180d03797ebd0c26adfc27276cc0682a04a0f8f Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois@gmx.com>
> Date: Thu, 8 Nov 2018 09:51:05 +0000
> Subject: [PATCH] gnu: Drop non-sbcl lisp support from Stumpwm 2018.05.
>
> StumpWM version 1.0.0 was the last version to support lisps other than
> sbcl. This renames the current version of Stumpwm to simply "stumpwm" instead
> of "sbcl-stumpwm" since it's redundant. However, we can keep version 1.0.0
> around if somebody wants a version with ecl.
>
> * gnu/packages/lisp.scm (sbcl-stumpwm): Rename to ...
I think “Rename to stumpwm” and delete line “(stumpwm): ... this.” is
better, but no strict opinion on that.
> (stumpwm): ... this.
> [name]: Rename to "stumpwm".
> [arguments]: Set #:asd-system-name to "stumpwm".
> [properties]: Replace ecl-variant with cl-source-variant.
> (cl-stumpwm): Inherit from stumpwm but override the name.
> (ecl-stumpwm): Remove.
> (ecl-stumpwm-1.0.0): New variable.
> (sbcl-stumpwm+slynk): Rename to ...
> (stumpwm+slynk): ... this.
Same.
> [name]: Rename to "stumpwm-with-slynk".
> [inherit]: Replace sbcl-stumpwm with stumpwm.
> [inputs]: Ditto.
> [arguments]: Ditto.
Rather “[inherit, inputs, arguments]: Replace sbcl-stumpwm with
stumpwm.”.
[…]
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-11-28 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 10:01 [bug#33311] [PATCH] gnu: Drop non-sbcl lisp support from Stumpwm 2018.05 Pierre Langlois
2018-11-25 22:05 ` Pierre Langlois
2018-11-26 13:37 ` Pierre Neidhardt
2018-11-28 16:25 ` Oleg Pykhalov [this message]
2018-11-28 17:01 ` Pierre Langlois
2018-12-02 12:06 ` Pierre Langlois
2018-12-05 4:34 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9a96ufh.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=33311@debbugs.gnu.org \
--cc=pierre.langlois@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).