unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#34232] [PATCH] gnu: rust: Package rust@1.29.2
@ 2019-01-28  6:50 Ivan Petkov
  2019-02-06 22:06 ` Ludovic Courtès
  0 siblings, 1 reply; 4+ messages in thread
From: Ivan Petkov @ 2019-01-28  6:50 UTC (permalink / raw)
  To: 34232

* gnu/packages/rust.scm (rust): renamed to rust-1.28
* gnu/packages/rust.scm (rust): Packaged rust@1.29.2 by inheriting from
rust@1.28.0 and only applying the necessary patches which were lacking
upstream
---
 gnu/packages/rust.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm
index 501736d89..179689973 100644
--- a/gnu/packages/rust.scm
+++ b/gnu/packages/rust.scm
@@ -749,7 +749,7 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\"
                    (("fn thin_lto_works") "#[ignore]\nfn thin_lto_works"))
                  #t)))))))))
 
-(define-public rust
+(define-public rust-1.28
   (let ((base-rust
          (rust-bootstrapped-package rust-1.27 "1.28.0"
                                     "11k4rn77bca2rikykkk9fmprrgjswd4x4kaq7fia08vgkir82nhx"
@@ -782,3 +782,13 @@ jemalloc = \"" jemalloc "/lib/libjemalloc_pic.a" "\"
                  #t))
              ;; The thinlto test should pass with llvm 6.
              (delete 'disable-thinlto-test))))))))
+
+(define-public rust
+  (let ((base-rust
+         (rust-bootstrapped-package rust-1.28 "1.29.2"
+                                    "1jb787080z754caa2w3w1amsygs4qlzj9rs1vy64firfmabfg22h"
+                                    #:patches
+                                    '("rust-1.25-accept-more-detailed-gdb-lines.patch"
+                                      "rust-reproducible-builds.patch"))))
+    (package
+      (inherit base-rust))))
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#34232] [PATCH] gnu: rust: Package rust@1.29.2
  2019-01-28  6:50 [bug#34232] [PATCH] gnu: rust: Package rust@1.29.2 Ivan Petkov
@ 2019-02-06 22:06 ` Ludovic Courtès
  2019-02-14  3:51   ` Ivan Petkov
  0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-02-06 22:06 UTC (permalink / raw)
  To: Ivan Petkov; +Cc: 34232

Hello Ivan,

Ivan Petkov <ivanppetkov@gmail.com> skribis:

> * gnu/packages/rust.scm (rust): renamed to rust-1.28
> * gnu/packages/rust.scm (rust): Packaged rust@1.29.2 by inheriting from
> rust@1.28.0 and only applying the necessary patches which were lacking
> upstream

Thanks for your patch!  I’ll leave the last word to Danny but this LGTM.

Danny, WDYT?  Please apply if you think it’s good.

Ludo’.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#34232] [PATCH] gnu: rust: Package rust@1.29.2
  2019-02-06 22:06 ` Ludovic Courtès
@ 2019-02-14  3:51   ` Ivan Petkov
  2019-02-14 16:57     ` bug#34232: " Danny Milosavljevic
  0 siblings, 1 reply; 4+ messages in thread
From: Ivan Petkov @ 2019-02-14  3:51 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 34232


> Thanks for your patch!  I’ll leave the last word to Danny but this LGTM.
> 
> Danny, WDYT?  Please apply if you think it’s good.


Hey Danny,

Did you have any feedback on this?

FWIW I’ve also started working on packaging rust-1.30.1 but that one needs
some local patching and I haven’t quite finished fleshing all the changes
out.

Happy to merge the patches if you think that's better for doing one upgrade
of the rust compiler, but I'm also open to keeping them separate if that's
easier to review!

Thanks,
--Ivan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#34232: [PATCH] gnu: rust: Package rust@1.29.2
  2019-02-14  3:51   ` Ivan Petkov
@ 2019-02-14 16:57     ` Danny Milosavljevic
  0 siblings, 0 replies; 4+ messages in thread
From: Danny Milosavljevic @ 2019-02-14 16:57 UTC (permalink / raw)
  To: Ivan Petkov; +Cc: 34232-done

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi Ivan,

On Wed, 13 Feb 2019 19:51:53 -0800
Ivan Petkov <ivanppetkov@gmail.com> wrote:

> Did you have any feedback on this?

Yes, I've applied it to master.

Thanks!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-14 16:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28  6:50 [bug#34232] [PATCH] gnu: rust: Package rust@1.29.2 Ivan Petkov
2019-02-06 22:06 ` Ludovic Courtès
2019-02-14  3:51   ` Ivan Petkov
2019-02-14 16:57     ` bug#34232: " Danny Milosavljevic

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).