unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
@ 2019-10-01 12:25 Ingo Ruhnke
  2019-10-01 23:55 ` Danny Milosavljevic
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Ruhnke @ 2019-10-01 12:25 UTC (permalink / raw)
  To: 37570

This fixes multi-monitor issues in XFCE and other Gtk+ apps.

* gnu/packages/gtk.scm: Add libxrandr input.
---
 gnu/packages/gtk.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 12972b75df..55c24c774c 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -753,6 +753,7 @@ application suites.")
       ("libxinerama" ,libxinerama)
       ("libxkbcommon" ,libxkbcommon)
       ("libxdamage" ,libxdamage)
+      ("libxrandr" ,libxrandr)
       ("mesa" ,mesa)
       ("pango" ,pango)
       ("wayland" ,wayland)
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
  2019-10-01 12:25 [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input Ingo Ruhnke
@ 2019-10-01 23:55 ` Danny Milosavljevic
  2019-10-02 18:46   ` Ingo Ruhnke
  0 siblings, 1 reply; 4+ messages in thread
From: Danny Milosavljevic @ 2019-10-01 23:55 UTC (permalink / raw)
  To: Ingo Ruhnke; +Cc: 37570

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hmm, gtk+ has a huge number of dependents.

Also, shouldn't gtk+ already have libxrandr in its inputs by virtue of gtk+
inheriting from gtk+-2, which does have it in its inputs?  Why doesn't it
work without the patch?

I suspect that other (xfce) packages actually should require libxrandr in THEIR
inputs, and it's missing there.

Of course adding it to propagated-inputs of gtk+ would "fix" (work around) the
problem, but that's usually not the correct place for it.




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input.
  2019-10-01 23:55 ` Danny Milosavljevic
@ 2019-10-02 18:46   ` Ingo Ruhnke
  2019-10-09 16:58     ` bug#37570: " Marius Bakke
  0 siblings, 1 reply; 4+ messages in thread
From: Ingo Ruhnke @ 2019-10-02 18:46 UTC (permalink / raw)
  To: 37570; +Cc: Danny Milosavljevic

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

The issue with Xfce specifically was that "gdk_monitor_get_model()" would
return NULL instead of the proper name and all the multi-monitor handling
would fall apart in turn, that seems like an gtk issue, not an Xfce issue.

As for "propagated-inputs", I put it there because that's where all the
other X11 libraries already are. Don't know exactly why, but it seems to
cause xrandr show up in the pkgconfig file which it wouldn't otherwise:

pkgconfig/gdk-3.0.pc:
Requires.private: ... xrandr ...

[-- Attachment #2: Type: text/html, Size: 717 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#37570: [PATCH] gnu: gtk+: Add libxrandr input.
  2019-10-02 18:46   ` Ingo Ruhnke
@ 2019-10-09 16:58     ` Marius Bakke
  0 siblings, 0 replies; 4+ messages in thread
From: Marius Bakke @ 2019-10-09 16:58 UTC (permalink / raw)
  To: Ingo Ruhnke, 37570-done; +Cc: Danny Milosavljevic

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hello Ingo,

Ingo Ruhnke <grumbel@gmail.com> writes:

> The issue with Xfce specifically was that "gdk_monitor_get_model()" would
> return NULL instead of the proper name and all the multi-monitor handling
> would fall apart in turn, that seems like an gtk issue, not an Xfce issue.
>
> As for "propagated-inputs", I put it there because that's where all the
> other X11 libraries already are. Don't know exactly why, but it seems to
> cause xrandr show up in the pkgconfig file which it wouldn't otherwise:
>
> pkgconfig/gdk-3.0.pc:
> Requires.private: ... xrandr ...

Thank you very much for this debugging work and patch.  Pushed to the
'staging' branch in 52b61e999101724c7e2d341586e9a6150614f208.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-09 16:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-01 12:25 [bug#37570] [PATCH] gnu: gtk+: Add libxrandr input Ingo Ruhnke
2019-10-01 23:55 ` Danny Milosavljevic
2019-10-02 18:46   ` Ingo Ruhnke
2019-10-09 16:58     ` bug#37570: " Marius Bakke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).