From: Marius Bakke <marius@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 41579-done@debbugs.gnu.org
Subject: bug#41579: [PATCH 0/2] Introduce 'cc-for-target'.
Date: Fri, 29 May 2020 15:58:22 +0200 [thread overview]
Message-ID: <87o8q64zcx.fsf@gnu.org> (raw)
In-Reply-To: <87eer3zyqn.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Mathieu Othacehe <othacehe@gnu.org> writes:
> Hello Marius,
>
>> To reduce duplication, the following patch introduces a 'cc-for-target'
>> procedure, so one can instead do:
>>
>> (string-append "CC=" ,(cc-for-target))
>>
>> ...and it will DTRT.
>
> This is definitely a nice improvement! Sometimes the issue also extends
> to AR and LD for instance.
>
> This has been discussed here[1]. Maybe we should deal with that directly
> in the build system, and provide suitable default values for CC, AR, LD
> & friends, when cross-compiling.
That makes sense. Can't think of any cases where setting these would
have an adverse effect, though I'm sure plenty of stuff will break. ;-)
> Anyway, your patch is already a big improvement and it LGTM.
Thanks for checking, pushed!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2020-05-29 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 17:11 [bug#41579] [PATCH 0/2] Introduce 'cc-for-target' Marius Bakke
2020-05-28 17:13 ` [bug#41579] [PATCH 1/2] utils: Add 'cc-for-target' Marius Bakke
2020-05-28 17:13 ` [bug#41579] [PATCH 2/2] gnu: Use 'cc-for-target' instead of custom implementations Marius Bakke
2020-05-28 18:04 ` [bug#41579] [PATCH 1/2] utils: Add 'cc-for-target' Tobias Geerinckx-Rice via Guix-patches via
2020-05-28 18:43 ` [bug#41579] [PATCH 0/2] Introduce 'cc-for-target' Mathieu Othacehe
2020-05-29 13:58 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8q64zcx.fsf@gnu.org \
--to=marius@gnu.org \
--cc=41579-done@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).