From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id x/Q3ArMX0V74QgAA0tVLHw (envelope-from ) for ; Fri, 29 May 2020 14:09:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yIAUObIX0V5bKwAAB5/wlQ (envelope-from ) for ; Fri, 29 May 2020 14:09:54 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74D4A9404CA for ; Fri, 29 May 2020 14:09:54 +0000 (UTC) Received: from localhost ([::1]:36198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jefhn-0003zw-ND for larch@yhetil.org; Fri, 29 May 2020 10:09:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jefXK-0003fg-Vo for guix-patches@gnu.org; Fri, 29 May 2020 09:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44144) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jefXK-00070a-JX for guix-patches@gnu.org; Fri, 29 May 2020 09:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jefXK-00048S-JO for guix-patches@gnu.org; Fri, 29 May 2020 09:59:02 -0400 Subject: bug#41579: [PATCH 0/2] Introduce 'cc-for-target'. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Fri, 29 May 2020 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41579 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 41579-done@debbugs.gnu.org Mail-Followup-To: 41579@debbugs.gnu.org, marius@gnu.org, marius@gnu.org Received: via spool by 41579-done@debbugs.gnu.org id=D41579.159076071315836 (code D ref 41579); Fri, 29 May 2020 13:59:02 +0000 Received: (at 41579-done) by debbugs.gnu.org; 29 May 2020 13:58:33 +0000 Received: from localhost ([127.0.0.1]:55686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jefWr-00047K-AF for submit@debbugs.gnu.org; Fri, 29 May 2020 09:58:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jefWq-000476-68 for 41579-done@debbugs.gnu.org; Fri, 29 May 2020 09:58:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39251) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jefWk-0006Sb-QH for 41579-done@debbugs.gnu.org; Fri, 29 May 2020 09:58:26 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:57160 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jefWj-0004Tm-4o; Fri, 29 May 2020 09:58:25 -0400 From: Marius Bakke In-Reply-To: <87eer3zyqn.fsf@gnu.org> References: <20200528171137.29146-1-marius@gnu.org> <87eer3zyqn.fsf@gnu.org> Date: Fri, 29 May 2020 15:58:22 +0200 Message-ID: <87o8q64zcx.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: hS6veadY9o2k --=-=-= Content-Type: text/plain Mathieu Othacehe writes: > Hello Marius, > >> To reduce duplication, the following patch introduces a 'cc-for-target' >> procedure, so one can instead do: >> >> (string-append "CC=" ,(cc-for-target)) >> >> ...and it will DTRT. > > This is definitely a nice improvement! Sometimes the issue also extends > to AR and LD for instance. > > This has been discussed here[1]. Maybe we should deal with that directly > in the build system, and provide suitable default values for CC, AR, LD > & friends, when cross-compiling. That makes sense. Can't think of any cases where setting these would have an adverse effect, though I'm sure plenty of stuff will break. ;-) > Anyway, your patch is already a big improvement and it LGTM. Thanks for checking, pushed! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7RFP4ACgkQoqBt8qM6 VPqudQf/ayvm/6A+MAbs9SJ5+dBWyi8G4m5ddGQ/lhZMY/l0n8J54x6Yz1LxEIzg /EMu4XpSgxIyhmNZsow8k+4jK7d0LBq8zkefmxj3/t6+oNu2tKiqYBnsip46GZ5M V3vNYGGrDCiHjw442jih7HQDNGtibXYnnTA9QJ5chiMwG+gWasCPomoQJDPuFK8H LWEb74ZgvLKv7pXj53HTtqYRnvj1oa7leZN7gXaKez11MYexxpIS9B+Sg4V3fBAi U9xmrD2x8u6lfYQU1YhdzC7KiuNviQozaSy//pg+goWd3PnEhD/POVm0bCbwVNoc /zaiHR/3UC3wYqu1idbOX0Az+Ft+0A== =Usjt -----END PGP SIGNATURE----- --=-=-=--