From: Michael Rohleder <mike@rohleder.de>
To: Marius Bakke <marius@gnu.org>
Cc: 41551@debbugs.gnu.org
Subject: [bug#41551] [PATCH] gnu: Add emacs-bm.
Date: Sat, 30 May 2020 19:55:31 +0200 [thread overview]
Message-ID: <87o8q5z4rw.fsf@rohleder.de> (raw)
In-Reply-To: <87ftbh3alu.fsf@gnu.org> (Marius Bakke's message of "Sat, 30 May 2020 13:50:37 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
Hi Marius,
you have an impressive pensum!
Thanks for the review!
Marius Bakke <marius@gnu.org> writes:
>> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
>
> Thanks! It LGTM but no longer applies, can you rebase it on the current
> master branch?
done.
>> + (synopsis "Visual Bookmarks for Emacs")
> ^^^
> Lowercase 'b'.
done.
>> + (description "This package provides visible, buffer local, bookmarks and
>> +the ability to jump forward and backward to the next bookmark.")
>
> The description reads a bit weird, I wonder if...
>
> "visible, buffer local bookmarks" (without the second comma)
>
> ...is more correct?
seems more correct, yes => done.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: Add emacs-bm. --]
[-- Type: text/x-patch, Size: 1545 bytes --]
From b2a6beadb1b82a524f5ef665d747b5f5252534cb Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Sat, 30 May 2020 19:50:02 +0200
Subject: [PATCH] gnu: Add emacs-bm.
* gnu/packages/emacs-xyz.scm (emacs-bm): New variable.
---
gnu/packages/emacs-xyz.scm | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6d82e1921c..9cf4cdd6a1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1918,6 +1918,26 @@ code@{emacs-wiki.el}, it facilitates using hyperlinks and doing full-text
searches. Unlike code@{emacs-wiki.el}, it can be combined with any format.")
(license license:gpl1+)))
+(define-public emacs-bm
+ (package
+ (name "emacs-bm")
+ (version "201905")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/joodland/bm.git")
+ (commit version)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
+ (build-system emacs-build-system)
+ (home-page "https://github.com/joodland/bm")
+ (synopsis "Visual bookmarks for Emacs")
+ (description "This package provides visible, buffer local bookmarks and
+the ability to jump forward and backward to the next bookmark.")
+ (license license:gpl2+)))
+
(define-public emacs-calfw
(package
(name "emacs-calfw")
--
2.26.2
[-- Attachment #1.3: Type: text/plain, Size: 338 bytes --]
--
In short, I think gcc should be fixed, or at the very least it should be a
_documented_ bug at which point I have no gripe with fixing it in the
kernel. But I refuse to work around undocumented bugs - that starts to
smell too much like microsoft, and then I might as well start using
Windows myself.
Linus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2020-05-30 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 23:41 [bug#41551] [PATCH] gnu: Add emacs-bm Michael Rohleder
2020-05-30 11:50 ` Marius Bakke
2020-05-30 17:55 ` Michael Rohleder [this message]
2020-05-30 21:16 ` bug#41551: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8q5z4rw.fsf@rohleder.de \
--to=mike@rohleder.de \
--cc=41551@debbugs.gnu.org \
--cc=marius@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).