[bug#41551] [PATCH] gnu: Add emacs-bm.

[Marius Bakke <marius@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

Michael Rohleder <mike@rohleder.de> writes:

> From edd01faf84a59499a9a83b336d55828aadd6bfa3 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Wed, 27 May 2020 01:37:42 +0200
> Subject: [PATCH] gnu: Add emacs-bm.
>
> * gnu/packages/emacs-xyz.scm (emacs-bm): New variable.

Thanks!  It LGTM but no longer applies, can you rebase it on the current
master branch?
  
> +(define-public emacs-bm
> +  (package
> +    (name "emacs-bm")
> +    (version "201905")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/joodland/bm.git")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "180b3rc13asrmsdh7v405d54jkrininvaj52xhp71vw91ng51dkn"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/joodland/bm")
> +    (synopsis "Visual Bookmarks for Emacs")
                        ^^^
              Lowercase 'b'.

> +    (description "This package provides visible, buffer local, bookmarks and
> +the ability to jump forward and backward to the next bookmark.")

The description reads a bit weird, I wonder if...

  "visible, buffer local bookmarks" (without the second comma)

...is more correct?

Can you send an updated patch?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]