unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <marius@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: 42096-done@debbugs.gnu.org
Subject: bug#42096: [PATCH] gnu: Add UFO: Alien Invasion.
Date: Thu, 02 Jul 2020 23:31:59 +0200	[thread overview]
Message-ID: <87o8oxzjqo.fsf@gnu.org> (raw)
In-Reply-To: <87lfk4gt83.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Marius Bakke <marius@gnu.org> writes:
>
>> This adds a pre-release/development version of a fairly large and
>> complex game.  I went with the pre-release because according to the
>> developers it is "mostly complete", and the previous version is four
>> years old and requires heaps of patches to work.
>>
>> I'm fairly confident in the packaging, but unsure about the version
>> identifier, and whether the warning in the description is sufficient.
>> Also, as this game is a mix of GPL2+ and GPL2, I went with the latter,
>> but the data files list both.  On second thought, they might also count
>> as a "combined works" and thus become GPL2-only.
>>
>> Finally, maybe it's worth mentioning in the description that it is a
>> clone/reimplementation of the famous (but proprietary) X-COM games.
>>
>> Comments welcome!
>
> Nice job! I tried to package it a few weeks ago, but stopped as it was
> getting too hairy.

Thanks.  :-)

> Small note: I see some CC=gcc flags, but I think the trend is to replace
> them where cross-compiling matters (which may not be the case here).

Right.  It also uses "CXX=g++", which does not have a 'cc-for-target'
companion yet, so I punted on this.  Besides, I expect more changes are
needed in order to actually cross-compile.

> I think the version is fine, packaging 2.5.X is a dead-end.

Thanks for checking, pushed in 0ceb7c191d5954658593153d03f043a7f2100cd1!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

      reply	other threads:[~2020-07-02 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-27 22:36 [bug#42096] [PATCH] gnu: Add UFO: Alien Invasion Marius Bakke
2020-06-30 21:05 ` Nicolas Goaziou
2020-07-02 21:31   ` Marius Bakke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8oxzjqo.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=42096-done@debbugs.gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).