From: "Ludovic Courtès" <ludo@gnu.org>
To: Jan Nieuwenhuizen <janneke@gnu.org>
Cc: 43581-done@debbugs.gnu.org
Subject: bug#43581: [PATCH] guix build: Add '--without-tests'.
Date: Sun, 27 Sep 2020 22:58:44 +0200 [thread overview]
Message-ID: <87o8lrdji3.fsf@gnu.org> (raw)
In-Reply-To: <877dskw6dq.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 23 Sep 2020 23:05:53 +0200")
Hi,
Jan Nieuwenhuizen <janneke@gnu.org> skribis:
>> * guix/scripts/build.scm (transform-package-tests): New procedure.
>> (%transformations, %transformation-options)
>
> Nitpick, use comma ^
>
>> show-transformation-options-help): Add it.
Oops yes, and I forgot to fix it before pushing. :-/
>> +Turning off tests leads to a different store item. Consequently, when
>> +using this option, anything that depends on @var{package} must be
>> +rebuilt, as in this example:
>
> This makes sense, so I'm curious about it's usefulness in practice, but
> there have been several times during porting sessions where I have
> disabled tests by editing the package.
Yeah, that’s the typical use case.
> $ time ./pre-inst-env guix build automake --without-tests=automake --verbosity=1
> The following derivation will be built:
> /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake-1.16.2.drv
> building /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake-1.16.2.drv...
> |offloading build of /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake-1.16.2.drv to 'kluit.dezyne.org'
> /gnu/store/7qsz3avcfk6b6am0zj9ahsmjy8x6drxr-automake-1.16.2
>
> real 0m14.316s
> user 0m1.203s
> sys 0m0.072s
That’s also one of the packages I had in mind. :-)
Ricardo Wurmus <rekado@elephly.net> skribis:
> This looks good to me. It’s much more convenient for the casual user
> than to clone the Guix repo and to edit the package definition there, or
> to extend the package collection with GUIX_PACKAGE_PATH or even a
> channel.
Yup.
> I suppose we’d have to fix all those packages that moved the check phase
> without also checking for the “#:tests?” keyword. There are quite a few
> of those that thus wouldn’t be affected by “--without-tests”.
Right, hopefully there aren’t too many of those.
Pushed as f458cfbcc54ed87b1a87dd9e150ea276f17eab74, thanks!
Ludo’.
next prev parent reply other threads:[~2020-09-27 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 20:42 [bug#43581] [PATCH] guix build: Add '--without-tests' Ludovic Courtès
2020-09-23 21:05 ` Jan Nieuwenhuizen
2020-09-27 20:58 ` Ludovic Courtès [this message]
2020-09-23 21:37 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8lrdji3.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43581-done@debbugs.gnu.org \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).