From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8KMDJx79cF/XbAAA0tVLHw (envelope-from ) for ; Sun, 27 Sep 2020 20:59:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yCTXIh79cF+mQAAAB5/wlQ (envelope-from ) for ; Sun, 27 Sep 2020 20:59:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26AEE9402AA for ; Sun, 27 Sep 2020 20:59:10 +0000 (UTC) Received: from localhost ([::1]:60880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMdlE-0001q3-PE for larch@yhetil.org; Sun, 27 Sep 2020 16:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMdl8-0001oH-Hh for guix-patches@gnu.org; Sun, 27 Sep 2020 16:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMdl8-0000R5-7v for guix-patches@gnu.org; Sun, 27 Sep 2020 16:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMdl8-0006KB-5E for guix-patches@gnu.org; Sun, 27 Sep 2020 16:59:02 -0400 Subject: bug#43581: [PATCH] guix build: Add '--without-tests'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 27 Sep 2020 20:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43581 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jan Nieuwenhuizen Cc: 43581-done@debbugs.gnu.org Mail-Followup-To: 43581@debbugs.gnu.org, ludo@gnu.org, ludo@gnu.org Received: via spool by 43581-done@debbugs.gnu.org id=D43581.160124033424294 (code D ref 43581); Sun, 27 Sep 2020 20:59:01 +0000 Received: (at 43581-done) by debbugs.gnu.org; 27 Sep 2020 20:58:54 +0000 Received: from localhost ([127.0.0.1]:50564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMdl0-0006Jl-AU for submit@debbugs.gnu.org; Sun, 27 Sep 2020 16:58:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMdky-0006JZ-NC for 43581-done@debbugs.gnu.org; Sun, 27 Sep 2020 16:58:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57273) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMdks-0000QU-KW; Sun, 27 Sep 2020 16:58:46 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43818 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kMdkr-0000XM-GG; Sun, 27 Sep 2020 16:58:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200923204249.12058-1-ludo@gnu.org> <877dskw6dq.fsf@gnu.org> Date: Sun, 27 Sep 2020 22:58:44 +0200 In-Reply-To: <877dskw6dq.fsf@gnu.org> (Jan Nieuwenhuizen's message of "Wed, 23 Sep 2020 23:05:53 +0200") Message-ID: <87o8lrdji3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: SmbSUa7tY549 Hi, Jan Nieuwenhuizen skribis: >> * guix/scripts/build.scm (transform-package-tests): New procedure. >> (%transformations, %transformation-options) > > Nitpick, use comma ^ > >> show-transformation-options-help): Add it. Oops yes, and I forgot to fix it before pushing. :-/ >> +Turning off tests leads to a different store item. Consequently, when >> +using this option, anything that depends on @var{package} must be >> +rebuilt, as in this example: > > This makes sense, so I'm curious about it's usefulness in practice, but > there have been several times during porting sessions where I have > disabled tests by editing the package. Yeah, that=E2=80=99s the typical use case. > $ time ./pre-inst-env guix build automake --without-tests=3Dautomake --ve= rbosity=3D1 > The following derivation will be built: > /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake-1.16.2.drv > building /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake-1.16.2.drv.= .. > |offloading build of /gnu/store/0m9qp0rf74d6sray1ip6h050fzmrrya3-automake= -1.16.2.drv to 'kluit.dezyne.org' > /gnu/store/7qsz3avcfk6b6am0zj9ahsmjy8x6drxr-automake-1.16.2 > > real 0m14.316s > user 0m1.203s > sys 0m0.072s That=E2=80=99s also one of the packages I had in mind. :-) Ricardo Wurmus skribis: > This looks good to me. It=E2=80=99s much more convenient for the casual = user > than to clone the Guix repo and to edit the package definition there, or > to extend the package collection with GUIX_PACKAGE_PATH or even a > channel. Yup. > I suppose we=E2=80=99d have to fix all those packages that moved the chec= k phase > without also checking for the =E2=80=9C#:tests?=E2=80=9D keyword. There = are quite a few > of those that thus wouldn=E2=80=99t be affected by =E2=80=9C--without-tes= ts=E2=80=9D. Right, hopefully there aren=E2=80=99t too many of those. Pushed as f458cfbcc54ed87b1a87dd9e150ea276f17eab74, thanks! Ludo=E2=80=99.