From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 43635@debbugs.gnu.org
Cc: rndd@tuta.io
Subject: [bug#43635] [PATCH] gnu: Add emacs-sqlite.
Date: Sun, 27 Sep 2020 14:31:57 +0200 [thread overview]
Message-ID: <87o8lr4czm.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <MIB7VYG--3-2@tuta.io> (Adam Kandur via Guix-patches via's message of "Sat, 26 Sep 2020 22:36:58 +0200 (CEST)")
Hello,
Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: Add emacs-sqlite.
>
> * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable.
Thank you!
Some comments follow.
> +(define-public emacs-sqlite.el
The same should be emacs-sqlite.
> + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797")
> + (revision "1"))
You need to provide a comment explaining why you're choosing a specific
commit instead of a tagged release (in this case, that's because there
is no tagged commit).
Also, mind the indentation. (revision ...) should be vertically aligned
with (commit ...)
> + (package
> + (name "emacs-sqlite.el")
See above.
> + (build-system emacs-build-system)
> + (version (git-version "0.0.0" revision commit))
The base version is "1.0" per keyword in the main Elisp file, not
"0.0.0".
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/cnngimenez/sqlite.el.git")
You can drop the ".git" suffix in the URL.
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd"))))
(base32 ...) should be moved on the line below.
> + (home-page "https://gitlab.com/cnngimenez/sqlite.el.git")
Likewise, please drop the ".git" suffix.
> + (synopsis "SQLite Interface for EmasLisp")
There's a typo in EmacsLisp, which I suggest to write "Emacs Lisp".
> + (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers:
> + @cnngimenez
> + @KIDD (Raimon Grau)")
This description is not useful. I suggest to use the one from EmacsWiki,
quoted here:
@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
information using the SQLite program through Elisp programming. It is
not intended as a user interface.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-09-27 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 20:36 [bug#43635] [PATCH] gnu: Add emacs-sqlite Adam Kandur via Guix-patches via
2020-09-27 12:31 ` Nicolas Goaziou [this message]
2020-09-27 13:18 ` [bug#43635] hope, this is right Adam Kandur via Guix-patches via
2020-10-01 13:42 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8lr4czm.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43635@debbugs.gnu.org \
--cc=rndd@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).