From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sP07ApeGcF/+JQAA0tVLHw (envelope-from ) for ; Sun, 27 Sep 2020 12:33:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KKadOZaGcF9qUwAAB5/wlQ (envelope-from ) for ; Sun, 27 Sep 2020 12:33:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6E50F940308 for ; Sun, 27 Sep 2020 12:33:26 +0000 (UTC) Received: from localhost ([::1]:35796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMVrn-0007Rk-O7 for larch@yhetil.org; Sun, 27 Sep 2020 08:33:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVrS-0007RO-Gf for guix-patches@gnu.org; Sun, 27 Sep 2020 08:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37039) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMVrR-0008EN-VW for guix-patches@gnu.org; Sun, 27 Sep 2020 08:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMVrR-0004GK-SW for guix-patches@gnu.org; Sun, 27 Sep 2020 08:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43635] [PATCH] gnu: Add emacs-sqlite. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 27 Sep 2020 12:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43635 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43635@debbugs.gnu.org Cc: rndd@tuta.io X-Debbugs-Original-To: Adam Kandur via Guix-patches via X-Debbugs-Original-Cc: 43635@debbugs.gnu.org, Adam Kandur Received: via spool by submit@debbugs.gnu.org id=B.160120993416330 (code B ref -1); Sun, 27 Sep 2020 12:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 12:32:14 +0000 Received: from localhost ([127.0.0.1]:48585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVqg-0004FF-49 for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:32:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:58418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVqf-0004F6-CJ for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVqe-0007J2-Lu for guix-patches@gnu.org; Sun, 27 Sep 2020 08:32:13 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:40163) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVqc-0008Av-7l for guix-patches@gnu.org; Sun, 27 Sep 2020 08:32:12 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id D6D67200002; Sun, 27 Sep 2020 12:32:05 +0000 (UTC) From: Nicolas Goaziou References: Date: Sun, 27 Sep 2020 14:31:57 +0200 In-Reply-To: (Adam Kandur via Guix-patches via's message of "Sat, 26 Sep 2020 22:36:58 +0200 (CEST)") Message-ID: <87o8lr4czm.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.232; envelope-from=mail@nicolasgoaziou.fr; helo=relay12.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 06:35:51 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.7 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: dUH1oHsXTtgE Hello, Adam Kandur via Guix-patches via writes: > Subject: [PATCH] gnu: Add emacs-sqlite. > > * gnu/packages/emacs-xyz.scm (emacs-sqlite): New variable. Thank you! Some comments follow. > +(define-public emacs-sqlite.el The same should be emacs-sqlite. > + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") > + (revision "1")) You need to provide a comment explaining why you're choosing a specific commit instead of a tagged release (in this case, that's because there is no tagged commit). Also, mind the indentation. (revision ...) should be vertically aligned with (commit ...) > + (package > + (name "emacs-sqlite.el") See above. > + (build-system emacs-build-system) > + (version (git-version "0.0.0" revision commit)) The base version is "1.0" per keyword in the main Elisp file, not "0.0.0". > + (source > + (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/cnngimenez/sqlite.el.git") You can drop the ".git" suffix in the URL. > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 (base32 "06ln4vijl8kii3nzc5cscgsadx1fqgxksflijd3ain83bn8g4wrd")))) (base32 ...) should be moved on the line below. > + (home-page "https://gitlab.com/cnngimenez/sqlite.el.git") Likewise, please drop the ".git" suffix. > + (synopsis "SQLite Interface for EmasLisp") There's a typo in EmacsLisp, which I suggest to write "Emacs Lisp". > + (description "This code was retrieved from the EmacsWiki at Dicember 26, 2013. At that point was two developers: > + @cnngimenez > + @KIDD (Raimon Grau)") This description is not useful. I suggest to use the one from EmacsWiki, quoted here: @code{sqlite.el} is a simple SqliteInterface for connecting and retrieving information using the SQLite program through Elisp programming. It is not intended as a user interface. Could you send an updated patch? Regards, -- Nicolas Goaziou