From: "Ludovic Courtès" <ludo@gnu.org>
To: Timothy Sample <samplet@ngyro.com>
Cc: 44427@debbugs.gnu.org
Subject: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker.
Date: Wed, 18 Nov 2020 22:45:42 +0100 [thread overview]
Message-ID: <87o8jujq49.fsf@gnu.org> (raw)
In-Reply-To: <87pn4ton2c.fsf@ngyro.com> (Timothy Sample's message of "Tue, 03 Nov 2020 21:47:23 -0500")
Hi Timothy,
Timothy Sample <samplet@ngyro.com> skribis:
> To make the test work, I made sure our Hackage and Stackage importers
> use base URLs that are parameters. Then, I used ‘with-http-server’ and
> ‘parameterize’d the URLs to use the local server. (This all follows the
> example of the SWH checker.) It might be clearer if the test were split
> in two, but the Stackage importer memoizes the list of packages sent
> from the Stackage server. That means that the two tests would have to
> be run in a certain order to work, which is pretty dodgy.
>
> Is the test too complicated to be worth it? I might be able to make it
> a little clearer, but I’m not sure it’s worth including at all.
> Thoughts?
I think it’s fine.
>>From 7e01e8adddeaba7a2c0b3a79425da26f3c2584df Mon Sep 17 00:00:00 2001
> From: Timothy Sample <samplet@ngyro.com>
> Date: Tue, 3 Nov 2020 15:30:28 -0500
> Subject: [PATCH] lint: Add 'check-haskell-stackage' checker.
>
> * guix/lint.scm (check-haskell-stackage): New procedure.
> (%network-dependent-checkers): Add 'haskell-stackage' checker.
> * guix/import/hackage.scm (%hackage-url): New variable.
> (hackage-source-url, hackage-cabal-url): Use it in place of a
> hard-coded string.
> * guix/import/stackage.scm (%stackage-url): Make it a parameter.
> (stackage-lts-info-fetch): Update accordingly.
> * tests/lint.scm ("hackage-stackage"): New test.
LGTM, thank you!
‘%stackage-updater’ only offers versions that are in LTS Stackage,
right?
Ludo’.
next prev parent reply other threads:[~2020-11-18 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 2:47 [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker Timothy Sample
2020-11-18 21:45 ` Ludovic Courtès [this message]
2020-11-22 3:21 ` bug#44427: " Timothy Sample
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8jujq49.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44427@debbugs.gnu.org \
--cc=samplet@ngyro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).