From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uASNASeWtV/GGgAA0tVLHw (envelope-from ) for ; Wed, 18 Nov 2020 21:46:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SH/1OCaWtV8CTQAA1q6Kng (envelope-from ) for ; Wed, 18 Nov 2020 21:46:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 908869402A0 for ; Wed, 18 Nov 2020 21:46:14 +0000 (UTC) Received: from localhost ([::1]:39386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfVHJ-000115-Cb for larch@yhetil.org; Wed, 18 Nov 2020 16:46:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfVH8-00010H-Gb for guix-patches@gnu.org; Wed, 18 Nov 2020 16:46:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfVH8-0003tz-7Z for guix-patches@gnu.org; Wed, 18 Nov 2020 16:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfVH8-00049U-6B for guix-patches@gnu.org; Wed, 18 Nov 2020 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44427] [PATCH] lint: Add 'check-haskell-stackage' checker. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Nov 2020 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Timothy Sample Cc: 44427@debbugs.gnu.org Received: via spool by 44427-submit@debbugs.gnu.org id=B44427.160573595215935 (code B ref 44427); Wed, 18 Nov 2020 21:46:02 +0000 Received: (at 44427) by debbugs.gnu.org; 18 Nov 2020 21:45:52 +0000 Received: from localhost ([127.0.0.1]:36733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVGx-00048x-Q1 for submit@debbugs.gnu.org; Wed, 18 Nov 2020 16:45:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfVGw-00048j-BS for 44427@debbugs.gnu.org; Wed, 18 Nov 2020 16:45:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34801) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfVGq-0003tH-Uv; Wed, 18 Nov 2020 16:45:44 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59032 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kfVGq-0001ii-EU; Wed, 18 Nov 2020 16:45:44 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87pn4ton2c.fsf@ngyro.com> Date: Wed, 18 Nov 2020 22:45:42 +0100 In-Reply-To: <87pn4ton2c.fsf@ngyro.com> (Timothy Sample's message of "Tue, 03 Nov 2020 21:47:23 -0500") Message-ID: <87o8jujq49.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: GMfx6x/5ln4i Hi Timothy, Timothy Sample skribis: > To make the test work, I made sure our Hackage and Stackage importers > use base URLs that are parameters. Then, I used =E2=80=98with-http-serve= r=E2=80=99 and > =E2=80=98parameterize=E2=80=99d the URLs to use the local server. (This = all follows the > example of the SWH checker.) It might be clearer if the test were split > in two, but the Stackage importer memoizes the list of packages sent > from the Stackage server. That means that the two tests would have to > be run in a certain order to work, which is pretty dodgy. > > Is the test too complicated to be worth it? I might be able to make it > a little clearer, but I=E2=80=99m not sure it=E2=80=99s worth including a= t all. > Thoughts? I think it=E2=80=99s fine. >>>From 7e01e8adddeaba7a2c0b3a79425da26f3c2584df Mon Sep 17 00:00:00 2001 > From: Timothy Sample > Date: Tue, 3 Nov 2020 15:30:28 -0500 > Subject: [PATCH] lint: Add 'check-haskell-stackage' checker. > > * guix/lint.scm (check-haskell-stackage): New procedure. > (%network-dependent-checkers): Add 'haskell-stackage' checker. > * guix/import/hackage.scm (%hackage-url): New variable. > (hackage-source-url, hackage-cabal-url): Use it in place of a > hard-coded string. > * guix/import/stackage.scm (%stackage-url): Make it a parameter. > (stackage-lts-info-fetch): Update accordingly. > * tests/lint.scm ("hackage-stackage"): New test. LGTM, thank you! =E2=80=98%stackage-updater=E2=80=99 only offers versions that are in LTS St= ackage, right? Ludo=E2=80=99.