From: "Ludovic Courtès" <ludo@gnu.org>
To: Simon Streit <simon@netpanic.org>
Cc: 54561@debbugs.gnu.org
Subject: [bug#54561] [PATCH 0/4] Add service declarations for Samba
Date: Fri, 08 Apr 2022 23:23:18 +0200 [thread overview]
Message-ID: <87o81b9smx.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220408182131.10271-1-simon@netpanic.org> (Simon Streit's message of "Fri, 8 Apr 2022 20:21:26 +0200")
Hi Simon,
Simon Streit <simon@netpanic.org> skribis:
> Please find attached an updated patch series.
It’s a huge amount of work that you did, and that’ll certainly be useful
to many!
> I've made slight changes as follows:
>
> * The reference to further config options in the manual have been removed.
> * Samba's (samba-activation config) procedure has been slightly modified,
> * better cleaned up, regarding the mkdirs. I've done more testing and it
> * appears that samba will only run when /var/{lib,log,run}/samba exist,
> including /var/lib/samba/private. In this case it is chmod now to o700 to
> be on the save side. Debian's directory structure is world readable though.
> In Arch it is o700. If anyone objects, please make it world readable. It
> appears that Samba lives and breathes in these directories, so they better
> be put there.
> * Regarding smb.conf -- while this service technically doesn't need it placed
> at /etc/samba -- is convenient to have it placed there for other tools part
> of the Samba family to read it, and so that others can quickly look into its
> configuration. I'll leave this for further debate whether it can stay there
> or not.
> * The packages samba and wsdd are included in profile-service-type so that they
> are generally available in the system profile.
I didn’t look at everything in detail, but overall that LGTM.
There’s a couple of things that I think would be worth adjusting though:
> services: Add samba service.
> doc: Add "Samba" chapter.
> doc: Add documentation for WSDD service.
> services: Add wsdd service.
> gnu: Add wsdd.
It seems patches are in the wrong order: I’d expect the wsdd package to
come before the wsdd service.
Regarding documentation: by convention, documentation for a service is
added in the same commit that adds the service, so that it’s
self-contained. Could you squash them?
Last, it would be great if you could add a system test under
gnu/tests/samba.scm. Essentially, that test would do what you probably
did manually already: spawning a VM running an OS with
‘samba-service-type’ and/or ‘wsdd-service-type’ and running an SMB
and/or WSD client to make sure the basics work. You can get inspiration
from other system tests there, and see:
https://guix.gnu.org/manual/devel/en/html_node/Running-the-Test-Suite.html
I have minor cosmetic comments that I’ll send separately.
Could you send a v3 addressing these issues?
Thanks!
Ludo’.
next prev parent reply other threads:[~2022-04-08 21:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 8:48 [bug#54561] [PATCH 0/4] Add service declarations for Samba Simon Streit
2022-03-24 21:10 ` [bug#54561] [PATCH 3/4] doc: Add documentation for WSDD service Simon Streit
2022-03-24 21:14 ` [bug#54561] [PATCH 4/4] services: Add wsdd service Simon Streit
2022-03-25 9:16 ` Simon Streit
2022-03-25 12:02 ` Simon Streit
2022-03-25 9:00 ` [bug#54561] [PATCH 1/4] services: Add samba service Simon Streit
2022-03-27 1:07 ` fesoj000
2022-03-27 14:13 ` Maxime Devos
2022-03-27 18:32 ` Simon Streit
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 0/5] Add service declarations for Samba Simon Streit
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 1/5] services: Add samba service Simon Streit
2022-04-08 21:26 ` [bug#54561] [PATCH 0/4] Add service declarations for Samba Ludovic Courtès
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 2/5] doc: Add "Samba" chapter Simon Streit
2022-04-08 21:35 ` [bug#54561] [PATCH 0/4] Add service declarations for Samba Ludovic Courtès
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 3/5] doc: Add documentation for WSDD service Simon Streit
2022-04-08 21:41 ` [bug#54561] [PATCH 0/4] Add service declarations for Samba Ludovic Courtès
2022-04-09 8:29 ` [bug#54561] v2 [PATCH 3/5] doc: Add documentation for WSDD service Maxime Devos
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 4/5] services: Add wsdd service Simon Streit
2022-04-08 21:43 ` [bug#54561] [PATCH 0/4] Add service declarations for Samba Ludovic Courtès
2022-04-08 18:21 ` [bug#54561] v2 [PATCH 5/5] gnu: Add wsdd Simon Streit
2022-04-08 21:23 ` Ludovic Courtès [this message]
2022-03-27 18:48 ` [bug#54561] [PATCH 1/4] services: Add samba service Simon Streit
2022-03-27 18:58 ` fesoj000
2022-03-25 9:01 ` [bug#54561] [PATCH 2/4] doc: Add "Samba" chapter Simon Streit
2022-03-27 1:07 ` fesoj000
2022-03-27 14:15 ` Maxime Devos
2022-03-27 18:51 ` Simon Streit
2022-03-25 15:14 ` [bug#54561] [PATCH] gnu: samba: Modify input list Simon Streit
2022-03-27 19:22 ` [bug#54561] [PATCH] gnu: libdaemon: fix build for riscv64 fesoj000
2022-03-27 19:23 ` fesoj000
2022-08-08 14:56 ` [bug#54561] [PATCH v3 0/4] Add samba and wsdd to services list simon
2022-08-08 14:56 ` [bug#54561] [PATCH v3 1/4] gnu: samba: Add avahi to inputs simon
2022-08-08 14:56 ` [bug#54561] [PATCH v3 2/4] services: Add samba service simon
2022-08-08 14:56 ` [bug#54561] [PATCH v3 3/4] gnu: Add wsdd simon
2022-08-08 14:56 ` [bug#54561] [PATCH v3 4/4] services: Add wsdd service simon
2022-09-24 7:48 ` bug#54561: [PATCH v3 0/4] Add samba and wsdd to services list Lars-Dominik Braun
2022-09-25 8:22 ` [bug#54561] " Lars-Dominik Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o81b9smx.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=54561@debbugs.gnu.org \
--cc=simon@netpanic.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).