From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SP4UGACoUGKNaQEAgWs5BA (envelope-from ) for ; Fri, 08 Apr 2022 23:24:16 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id oFrMEACoUGKlCAAAG6o9tA (envelope-from ) for ; Fri, 08 Apr 2022 23:24:16 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C759D1F7FD for ; Fri, 8 Apr 2022 23:24:15 +0200 (CEST) Received: from localhost ([::1]:34530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncw5W-0005Im-En for larch@yhetil.org; Fri, 08 Apr 2022 17:24:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncw5K-0005IM-Fo for guix-patches@gnu.org; Fri, 08 Apr 2022 17:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncw5K-0003wo-72 for guix-patches@gnu.org; Fri, 08 Apr 2022 17:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ncw5J-0008Hb-Ut for guix-patches@gnu.org; Fri, 08 Apr 2022 17:24:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54561] [PATCH 0/4] Add service declarations for Samba Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Apr 2022 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54561 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Streit Cc: 54561@debbugs.gnu.org Received: via spool by 54561-submit@debbugs.gnu.org id=B54561.164945300931795 (code B ref 54561); Fri, 08 Apr 2022 21:24:01 +0000 Received: (at 54561) by debbugs.gnu.org; 8 Apr 2022 21:23:29 +0000 Received: from localhost ([127.0.0.1]:36170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncw4m-0008Gj-KA for submit@debbugs.gnu.org; Fri, 08 Apr 2022 17:23:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncw4l-0008GK-Bg for 54561@debbugs.gnu.org; Fri, 08 Apr 2022 17:23:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncw4g-0003pC-1R; Fri, 08 Apr 2022 17:23:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=E1Jq6NIwGwd/3fFZH8uBgr0EkxTUYfQUd5Kuv7KT5lk=; b=MC52oQsfOAwsnm0lQSa+ 96JqL7d5rKxRJ1j5fut8ENZBYnD9la8DUam11XVkihaHoTPNTXXtGTWF/nZ6JBZUraKvmu5scejoS Et5C0xZYiWozSyrgA9wI3LNNlu0SYSvQ94lNAMIXPA4v5lk6ga3r//xSIh4gsOHVaTsMNdRDtfIoP cwvS4kcT1VSEJkyxDFhItRTyD8OKubSSYHYkwr4l/SVSTrovbwnA5upMnYWUjB/3cfIE7CdPIsW17 Qo9Ls2uPx8G8GwXlpF+youny4tqbrjzvi6R97xakcK2BJRaXX4GCTdl/C0IViHfHTmFk/UJwTVnGu bFiKxX8f5mCITg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:49434 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncw4f-00037s-8c; Fri, 08 Apr 2022 17:23:21 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <02c2e04f0ef7404aab26e2c590cf3cd44634c74d.camel@telenet.be> <20220408182131.10271-1-simon@netpanic.org> Date: Fri, 08 Apr 2022 23:23:18 +0200 In-Reply-To: <20220408182131.10271-1-simon@netpanic.org> (Simon Streit's message of "Fri, 8 Apr 2022 20:21:26 +0200") Message-ID: <87o81b9smx.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649453055; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=E1Jq6NIwGwd/3fFZH8uBgr0EkxTUYfQUd5Kuv7KT5lk=; b=bsfDBoPxrRpUAxNCFPw6hXd8mOaEjrqiyWg34+AXOeTcxJgHGT/5HM42Zc0KZgjxVC5SUx hSI9rgyWIrI/WXEtM41j7TGqG5TcNVdYgLsdQ9ZuyV3vefKmO+OLMaaT6jNINhq3YAixsn edNrgtzEaRoShNoabHlBHDpgtWv05ZT/1wnVLOZxWUaZOwuq4eJD7zlQHXFmylSe9Ekr4p DPTcESnbniJ2PLGtHge5tYLyIdLccy3pWO4XorVdoNfLCo7wX58lESwn/ypgpgIVpR0MNO wD1XJceh0UMkEOED6VRrs9fX3dMEgSw9N5GhGaOm9yI0Yc0qwQuunR5eyxFmQA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649453055; a=rsa-sha256; cv=none; b=Zt4+8gMfeeKPkkCAfwYtZZ0LrKPTZtpo8N1UKijFwIz6L7T7uwD+wqBc+7m/8TSGN0cxTO oxlIsIlB8veeLU/+Z7OAbpSzJoV03FQdzp7yQ5CguwWeW/EguYDACIADbhmnvp1plQTbo/ VqXc7/pYcVAQwE9ej2Mz2iMM4XjLLYB9PXiyO5MVFScCZLz0qivPKFF2G9Um2SshMJMtb7 646DsjgrZiT+i71a52hbUwdA7YTBo5RR0abBfL7E8El0xDu598TGtOgNRv6zAp6DtD/2Bp 1x4qpO2fir1nr7TuzxfXy/bmbuN/2UOkpj/0PtDaaVMwFZrDd6g19Yr8J2alsA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MC52oQsf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.27 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MC52oQsf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C759D1F7FD X-Spam-Score: -3.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: L4daBe2mVOGg Hi Simon, Simon Streit skribis: > Please find attached an updated patch series. It=E2=80=99s a huge amount of work that you did, and that=E2=80=99ll certai= nly be useful to many! > I've made slight changes as follows: > > * The reference to further config options in the manual have been remove= d. > * Samba's (samba-activation config) procedure has been slightly modified, > * better cleaned up, regarding the mkdirs. I've done more testing and it > * appears that samba will only run when /var/{lib,log,run}/samba exist, > including /var/lib/samba/private. In this case it is chmod now to o70= 0 to > be on the save side. Debian's directory structure is world readable t= hough. > In Arch it is o700. If anyone objects, please make it world readable.= It > appears that Samba lives and breathes in these directories, so they be= tter > be put there.=20 > * Regarding smb.conf -- while this service technically doesn't need it p= laced > at /etc/samba -- is convenient to have it placed there for other tools= part > of the Samba family to read it, and so that others can quickly look in= to its > configuration. I'll leave this for further debate whether it can stay= there > or not. > * The packages samba and wsdd are included in profile-service-type so th= at they > are generally available in the system profile. I didn=E2=80=99t look at everything in detail, but overall that LGTM. There=E2=80=99s a couple of things that I think would be worth adjusting th= ough: > services: Add samba service. > doc: Add "Samba" chapter. > doc: Add documentation for WSDD service. > services: Add wsdd service. > gnu: Add wsdd. It seems patches are in the wrong order: I=E2=80=99d expect the wsdd packag= e to come before the wsdd service. Regarding documentation: by convention, documentation for a service is added in the same commit that adds the service, so that it=E2=80=99s self-contained. Could you squash them? Last, it would be great if you could add a system test under gnu/tests/samba.scm. Essentially, that test would do what you probably did manually already: spawning a VM running an OS with =E2=80=98samba-service-type=E2=80=99 and/or =E2=80=98wsdd-service-type=E2= =80=99 and running an SMB and/or WSD client to make sure the basics work. You can get inspiration from other system tests there, and see: https://guix.gnu.org/manual/devel/en/html_node/Running-the-Test-Suite.html I have minor cosmetic comments that I=E2=80=99ll send separately. Could you send a v3 addressing these issues? Thanks! Ludo=E2=80=99.