From: Z572 via Guix-patches via <guix-patches@gnu.org>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 63839@debbugs.gnu.org
Subject: [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64.
Date: Sun, 11 Jun 2023 22:48:20 +0800 [thread overview]
Message-ID: <tencent_1AFC29EB9C973794BCD4C66F2EA45E67050A@qq.com> (raw)
Message-ID: <87o7lmrqt2.fsf@qq.com> (raw)
In-Reply-To: <87ilc08ucn.fsf@jpoiret.xyz>
Josselin Poiret via Guix-patches via <guix-patches@gnu.org> writes:
> [[PGP Signed Part:Undecided]]
> Hi,
>
> Z572 via Guix-patches via <guix-patches@gnu.org> writes:
>
>
>> + ;; riscv-pk can only be built for riscv64.
>> + (if (string-prefix? "riscv64" (%current-system))
>> + '()
>> + (list
>> + #:target "riscv64-linux-gnu"))
>
> I don't think that's a good idea, in general, consumers of the package
> should be the ones specifying for which arch this package builds. For
> that purpose, there's the supported-systems field of the package record
> type. It's not good in general to hardcode targets in package
> definitions.
look it's name.
because it doesn't make sense to target other targets, like `u-boot-sifive-unmatched' or `opensbi-generic'.
>
> Best,
--
over
next prev parent reply other threads:[~2023-06-11 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 12:10 [bug#63839] [PATCH] gnu: riscv-pk: don't target riscv64-linux-gnu when current system is riscv64 Z572 via Guix-patches via
2023-06-06 15:48 ` Josselin Poiret via Guix-patches via
[not found] ` <87o7lmrqt2.fsf@qq.com>
2023-06-11 14:48 ` Z572 via Guix-patches via [this message]
2023-08-25 13:11 ` Josselin Poiret via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_1AFC29EB9C973794BCD4C66F2EA45E67050A@qq.com \
--to=guix-patches@gnu.org \
--cc=63839@debbugs.gnu.org \
--cc=873216071@qq.com \
--cc=dev@jpoiret.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).