From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Rikard Nordgren <hrn@posteo.net>
Cc: 63729-done@debbugs.gnu.org
Subject: bug#63729: [PATCH] gnu: Add greaseweazle-host-tools.
Date: Sat, 01 Jul 2023 12:17:30 +0200 [thread overview]
Message-ID: <87o7kwj5qd.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <5943592cd6e0672d17fae2d5ff0f2db124be3631.1685042019.git.hrn@posteo.net> (Rikard Nordgren's message of "Thu, 25 May 2023 19:17:05 +0000")
Hello,
Rikard Nordgren <hrn@posteo.net> writes:
> ---
> gnu/packages/disk.scm | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
Applied with a proper commit message and changes described below. Thank you.
> +(define-public greaseweazle-host-tools
> + (package
> + (name "greaseweazle-host-tools")
> + (version "1.12")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/keirf/greaseweazle")
> + (commit "v1.12")))
I re-used the version here:
(commit (string-append "v" version))
> + (arguments
> + `(#:phases (modify-phases %standard-phases
I used G-expressions:
(arguments (list #:phases #~(modify-phases ...)))
> + (add-before 'build 'setuptools-version
> + (lambda _
> + (setenv "SETUPTOOLS_SCM_PRETEND_VERSION" "1.8") #t))
No need for trailing #T at the end of phases; il removed it.
> + (add-after 'install 'install-udev-rules
> + (lambda* (#:key outputs #:allow-other-keys)
I removed the outputs argument...
> + (install-file "scripts/49-greaseweazle.rules"
> + (string-append (assoc-ref outputs "out")
... and used (string-append #$output ...)
> + "/lib/udev/rules.d/")))))))
> + (native-inputs (list python-setuptools-scm))
> + (propagated-inputs (list python-bitarray python-pyserial python-requests
> + python-crcmod))
Indentation is surprising here. I changed it.
> + (synopsis "Tools for accessing a floppy drive at the raw flux level")
> + (description
> + "The host tools for controlling a Greaseweazle: an Open Source USB device
> +capable of reading and writing raw data on nearly any type of floppy disk")
Descriptions should consist of full sentences:
"This package provides host tools for..."
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-07-01 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 19:17 [bug#63729] [PATCH] gnu: Add greaseweazle-host-tools Rikard Nordgren
2023-07-01 10:17 ` Nicolas Goaziou [this message]
2023-07-02 18:08 ` [bug#63729] Thanks Rikard Nordgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7kwj5qd.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=63729-done@debbugs.gnu.org \
--cc=hrn@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).