From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mBbCNGv9n2QhjgAASxT56A (envelope-from ) for ; Sat, 01 Jul 2023 12:18:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aGVONGv9n2TLIgAAauVa8A (envelope-from ) for ; Sat, 01 Jul 2023 12:18:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ADD751B52B for ; Sat, 1 Jul 2023 12:18:19 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1688206699; a=rsa-sha256; cv=none; b=PbChubSsXxuZp0HQ2SlG+oQ4yOmzKWJsnxhpI9O+NkiRpIRJnjHyP46ZIoVEbIASueIFU+ q1+AWP+k7QBrky3sol47LE46bIwKgQrdGfQGQu3bBf+Wts/s9kAa/D1em7LxJIfZaJSH/6 eaa/MzrGut3e7B7wSjlz3tFAjyyLV6BULLh2sKBAk1gW08N0i4HhRNJRbCMX/O7uVPOtlo 3aVmvBEbE/coMfAj6ldNfcp/apcLEUTwnSHwUZ2kN5ScIuj06ObMLfaVKq0RTWxwJHaA2T vbTMkZyh1+DloOIMEx5nNfzPj6/0WeBJKPTbz0sapGM7y4WHqzeMozGUQgX1/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1688206699; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=Z3g6eov1cieSP/tUNrE6zsgOTbJF5OIDYiR9vlKhhYY=; b=OWZXUIN33UwJmftmkiV72NRpNA3kuoP90BeuEvbB5stTSlPjW3BuYQ9eXAm2fhkGkt5iNU OzVKW4w/Da6GYLIxqPQo341S5O4FK7JTN+0wZ+16dh4Q7r/y0K9PdOvq4EOsjfc7+Ml1ZU 35Njj05/m3msMYr+ENof6gi3kaK/BW3huwSHWW3z+xhyswaJnhw460+dArPcDv+5r2kIGn GjRmvt4wjKTGxjeRc+QkkkfWeo1ex+6eYzxfZcDIbM9EfXw8eD7HhlcLZti7pBwDNr+9FI MGnLAws9TT4Ca4fQHogHIPKCVogU59/h8lxI7XAb98jYajz9sLARJfAuwU2XiA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFXg4-0007Rc-Mf; Sat, 01 Jul 2023 06:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFXg2-0007R1-SF for guix-patches@gnu.org; Sat, 01 Jul 2023 06:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFXg2-0001Im-Ji for guix-patches@gnu.org; Sat, 01 Jul 2023 06:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qFXg2-0008SN-F7 for guix-patches@gnu.org; Sat, 01 Jul 2023 06:18:02 -0400 Subject: bug#63729: [PATCH] gnu: Add greaseweazle-host-tools. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 01 Jul 2023 10:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rikard Nordgren Cc: 63729-done@debbugs.gnu.org Mail-Followup-To: 63729@debbugs.gnu.org, mail@nicolasgoaziou.fr, hrn@posteo.net Received: via spool by 63729-done@debbugs.gnu.org id=D63729.168820666832480 (code D ref 63729); Sat, 01 Jul 2023 10:18:02 +0000 Received: (at 63729-done) by debbugs.gnu.org; 1 Jul 2023 10:17:48 +0000 Received: from localhost ([127.0.0.1]:56667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFXfn-0008Ro-UN for submit@debbugs.gnu.org; Sat, 01 Jul 2023 06:17:48 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFXfm-0008Ra-FC for 63729-done@debbugs.gnu.org; Sat, 01 Jul 2023 06:17:47 -0400 X-GND-Sasl: mail@nicolasgoaziou.fr X-GND-Sasl: mail@nicolasgoaziou.fr Received: by mail.gandi.net (Postfix) with ESMTPSA id CBA3FFF805; Sat, 1 Jul 2023 10:17:39 +0000 (UTC) From: Nicolas Goaziou References: <5943592cd6e0672d17fae2d5ff0f2db124be3631.1685042019.git.hrn@posteo.net> Date: Sat, 01 Jul 2023 12:17:30 +0200 In-Reply-To: <5943592cd6e0672d17fae2d5ff0f2db124be3631.1685042019.git.hrn@posteo.net> (Rikard Nordgren's message of "Thu, 25 May 2023 19:17:05 +0000") Message-ID: <87o7kwj5qd.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -1.86 X-Migadu-Queue-Id: ADD751B52B X-Spam-Score: -1.86 X-TUID: UhzvF/g7Dm6i Hello, Rikard Nordgren writes: > --- > gnu/packages/disk.scm | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) Applied with a proper commit message and changes described below. Thank you. > +(define-public greaseweazle-host-tools > + (package > + (name "greaseweazle-host-tools") > + (version "1.12") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/keirf/greaseweazle") > + (commit "v1.12"))) I re-used the version here: (commit (string-append "v" version)) > + (arguments > + `(#:phases (modify-phases %standard-phases I used G-expressions: (arguments (list #:phases #~(modify-phases ...))) > + (add-before 'build 'setuptools-version > + (lambda _ > + (setenv "SETUPTOOLS_SCM_PRETEND_VERSION" "1.8") #t)) No need for trailing #T at the end of phases; il removed it. > + (add-after 'install 'install-udev-rules > + (lambda* (#:key outputs #:allow-other-keys) I removed the outputs argument... > + (install-file "scripts/49-greaseweazle.rules" > + (string-append (assoc-ref outputs "out") ... and used (string-append #$output ...) > + "/lib/udev/rules.d/"))))))) > + (native-inputs (list python-setuptools-scm)) > + (propagated-inputs (list python-bitarray python-pyserial python-requests > + python-crcmod)) Indentation is surprising here. I changed it. > + (synopsis "Tools for accessing a floppy drive at the raw flux level") > + (description > + "The host tools for controlling a Greaseweazle: an Open Source USB device > +capable of reading and writing raw data on nearly any type of floppy disk") Descriptions should consist of full sentences: "This package provides host tools for..." Regards, -- Nicolas Goaziou