[bug#66733] [PATCH v2] gnu: abseil-cpp: Update to 20230802.1.

["Ludovic Courtès" <ludo@gnu.org>]

Hi,

Greg Hogan <code@greghogan.com> skribis:

> v2: fix for wording in commit header.
>
> * gnu/packages/cpp.scm (abseil-cpp): Update to 20230802.1.
> [arguments]<#:phases>: Add phase to set timezone environment variable.
> * gnu/packages/cpp.scm (abseil-cpp-20220623.1): Keep old version.
> * gnu/packages/cpp.scm (abseil-cpp-for-c++-standard): Accept package to
> inherit from.
> * gnu/packages/cpp.scm (abseil-cpp-cxxstd11, abseil-cpp-cxxstd17):
> Inherit from latest supported version.

[...]

> +          #~(modify-phases #$phases
> +              (add-before 'check 'set-env-vars
> +                (lambda* (#:key inputs #:allow-other-keys)
> +                 ;; absl_time_test requires this environment variable.
> +                 (setenv "TZDIR" (string-append (assoc-ref %build-inputs "source")

This could be written like so:

  (setenv "TZDIR" (string-append #$(package-source this-package) …))

or referring to ‘inputs’ rather than ‘%build-inputs’.

Apart from that, it LGTM… but time has passed and it no longer
applies. :-/

Could you rebase it and resend?

Thanks and apologies for the delay!

Ludo’.