From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id GEtUFpUTXmVhHQAAauVa8A:P1 (envelope-from ) for ; Wed, 22 Nov 2023 15:43:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GEtUFpUTXmVhHQAAauVa8A (envelope-from ) for ; Wed, 22 Nov 2023 15:43:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A62043F19 for ; Wed, 22 Nov 2023 15:43:33 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WgOwR7JV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1700664213; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pGRIGJlWS1pJ0oZ2570bTLeXLwkZ/EijTLG+HiPuhu0=; b=Kapw5QR4i4MaUeYSfR0E32Tl1VKeP+Aczu8vS3LH4UHhdv9UHRt+GKAexdfmUxyet5JY1j +hMo+YDTVz1sGYSuSIrTEN2ugRejWRTzSU1FpCUB2b9PBUMwCv2xbfHOIZkENoCjbe51Cv bAExQ/eymUILIdVQvMbSJ4Ux9dh0dt3cCdSmGS6GO66Kl8xLPS8u48huqKMfTDTO2LzoiL 15jmX9UPwAsP8Mzsqe34DuC74pBhxg8K61N1xjYWRFUDAVWSqgceGoAuXy2FPZyEGofOPd deuz2+5KzmkNmPzfo4ui355VMA9N0EuGwqbHhgHpHZhcP+zAlDnOlGvAkEvybA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=WgOwR7JV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1700664213; a=rsa-sha256; cv=none; b=hHL0mw/DF6ekwWpgjQcwytvMsxJk70VODMTx5pMJCePwm8NEgBzaumPa/NM9+j/RxKttgE 3M5NcL5Wb54zRA14BgvNy1+jDmtyTtXWCxNfwPt41+Nk5Diy7C3YZ2dByMq8Lj3QroW8Hv wxycL3fM41QcJR+D4sP/3ugKlWVZxcG6JT9fTXae7tWRGhi4+Tfbfyv85afhR9OeEcIEQF AaFUvDsu+CLgFa7xrL4eTjJ3rBbk8iA3l2j6xdcGN+qPw9Sp5NG+b9uaN5dkFF0pAyI0Gb WBxon87YA/9u6B1PPUSeCwx5KbLh5Z/kAFm1N+lH67W+geQDcjRwn20MDb0DSg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r5oRS-0007JJ-Ub; Wed, 22 Nov 2023 09:43:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5oRP-0007Is-Fo for guix-patches@gnu.org; Wed, 22 Nov 2023 09:42:59 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r5oRP-0007aw-7J for guix-patches@gnu.org; Wed, 22 Nov 2023 09:42:59 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r5oRS-0004P0-Ep for guix-patches@gnu.org; Wed, 22 Nov 2023 09:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#66733] [PATCH v2] gnu: abseil-cpp: Update to 20230802.1. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Nov 2023 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66733 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Greg Hogan Cc: 66733@debbugs.gnu.org Received: via spool by 66733-submit@debbugs.gnu.org id=B66733.170066412316820 (code B ref 66733); Wed, 22 Nov 2023 14:43:02 +0000 Received: (at 66733) by debbugs.gnu.org; 22 Nov 2023 14:42:03 +0000 Received: from localhost ([127.0.0.1]:58550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5oQL-0004Mo-2a for submit@debbugs.gnu.org; Wed, 22 Nov 2023 09:42:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r5oQJ-0004Mc-C6 for 66733@debbugs.gnu.org; Wed, 22 Nov 2023 09:41:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5oQA-0007Rq-NV; Wed, 22 Nov 2023 09:41:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=pGRIGJlWS1pJ0oZ2570bTLeXLwkZ/EijTLG+HiPuhu0=; b=WgOwR7JVcf/QoAiBPKxU X34SJzaYq6FQHkpIYAqc+o/jlPOq3AYfahH8rkjwvWJ0borbZSUx0DEWEvBil1R35zQXWVbhDbpzM Hvn43XeIUDL5xzYaS25YSqHKZJSfq5qvWiiFdjggPWgJOSeS9lBFJPT49lrSASwQ+HVZK18g1KfvW BXFYm0y8iIPLGvOwG1TaWT4m+G071e5mMxd3WBpzE16WOXT0AMqxJjg6lc1jh6iHYzARtiPYhyX1v 8OBmN9h19SRbm4K9BslegN/L1DVOBLEixOsScqYLRHRvzROEGSM6bY+ymCBomeO0mIukGjyiRkRHM 6tVY4U3Q43H++A==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <20231024193756.253478-1-code@greghogan.com> (Greg Hogan's message of "Tue, 24 Oct 2023 19:37:49 +0000") References: <20231024192441.240355-1-code@greghogan.com> <20231024193756.253478-1-code@greghogan.com> Date: Wed, 22 Nov 2023 15:41:40 +0100 Message-ID: <87o7fllujf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.82 X-Spam-Score: -6.82 X-Migadu-Queue-Id: 2A62043F19 X-Migadu-Scanner: mx13.migadu.com X-TUID: W3g89mI3dXzR Hi, Greg Hogan skribis: > v2: fix for wording in commit header. > > * gnu/packages/cpp.scm (abseil-cpp): Update to 20230802.1. > [arguments]<#:phases>: Add phase to set timezone environment variable. > * gnu/packages/cpp.scm (abseil-cpp-20220623.1): Keep old version. > * gnu/packages/cpp.scm (abseil-cpp-for-c++-standard): Accept package to > inherit from. > * gnu/packages/cpp.scm (abseil-cpp-cxxstd11, abseil-cpp-cxxstd17): > Inherit from latest supported version. [...] > + #~(modify-phases #$phases > + (add-before 'check 'set-env-vars > + (lambda* (#:key inputs #:allow-other-keys) > + ;; absl_time_test requires this environment variable. > + (setenv "TZDIR" (string-append (assoc-ref %build-inputs= "source") This could be written like so: (setenv "TZDIR" (string-append #$(package-source this-package) =E2=80=A6)) or referring to =E2=80=98inputs=E2=80=99 rather than =E2=80=98%build-inputs= =E2=80=99. Apart from that, it LGTM=E2=80=A6 but time has passed and it no longer applies. :-/ Could you rebase it and resend? Thanks and apologies for the delay! Ludo=E2=80=99.